Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
"@storybook/theming": "^8.3.7",
"@tailwindcss/container-queries": "^0.1.1",
"@tanstack/eslint-plugin-query": "^4.38.0",
"@tanstack/react-query-devtools": "^4.29.6",
"@tanstack/react-query-devtools": "^5.90.1",
"@testing-library/dom": "10.3.2",
Comment on lines +112 to 113
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The ReactQueryDevtools component is missing the required client prop following an upgrade to v5, which will cause a runtime crash when the component renders.
  • Description: The upgrade of @tanstack/react-query-devtools to version 5 introduces a breaking API change. The ReactQueryDevtools component now requires a client prop, which is not provided in its current usage in src/App.tsx. According to the library's documentation, this missing prop will cause a runtime error when the component attempts to render, leading to an application crash in any environment where the devtools are included. The repository context also confirms that the v5 devtools have a strict peer dependency on @tanstack/react-query v5 and will not function correctly otherwise.

  • Suggested fix: Add the required client prop to the ReactQueryDevtools component in src/App.tsx. Since the v5 devtools are only compatible with v5 clients, the queryClientV5 instance should be passed. The implementation should be updated to <ReactQueryDevtools client={queryClientV5} initialIsOpen={false} />.
    severity: 0.85, confidence: 0.98

Did we get this right? 👍 / 👎 to inform future reviews.

"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^16.0.0",
Expand Down
67 changes: 15 additions & 52 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5001,15 +5001,6 @@ __metadata:
languageName: node
linkType: hard

"@tanstack/match-sorter-utils@npm:^8.7.0":
version: 8.15.1
resolution: "@tanstack/match-sorter-utils@npm:8.15.1"
dependencies:
remove-accents: "npm:0.5.0"
checksum: 10c0/a947c280093ed0214c3b1c6d9219b1a98cd000815891cb313f2a3e8cc01505a6d3bf358ba8273556804e0580a51e110a43ececabf0eec7386450662d827b0fa9
languageName: node
linkType: hard

"@tanstack/query-core@npm:4.36.1":
version: 4.36.1
resolution: "@tanstack/query-core@npm:4.36.1"
Expand All @@ -5024,18 +5015,22 @@ __metadata:
languageName: node
linkType: hard

"@tanstack/react-query-devtools@npm:^4.29.6":
version: 4.36.1
resolution: "@tanstack/react-query-devtools@npm:4.36.1"
"@tanstack/query-devtools@npm:5.90.1":
version: 5.90.1
resolution: "@tanstack/query-devtools@npm:5.90.1"
checksum: 10c0/3b69e5441438acf0e753adbf187abf54b5b2e19d7c6d1e465d97278cb8c248bb86d3be193092d50414e4093cbf014093103517cb523daae003e53c867f3c11c2
languageName: node
linkType: hard

"@tanstack/react-query-devtools@npm:^5.90.1":
version: 5.90.1
resolution: "@tanstack/react-query-devtools@npm:5.90.1"
dependencies:
"@tanstack/match-sorter-utils": "npm:^8.7.0"
superjson: "npm:^1.10.0"
use-sync-external-store: "npm:^1.2.0"
"@tanstack/query-devtools": "npm:5.90.1"
peerDependencies:
"@tanstack/react-query": ^4.36.1
react: ^16.8.0 || ^17.0.0 || ^18.0.0
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0
checksum: 10c0/7b5f31a90474bf45fce627d6831537a8a8e2fe5b588e9149ca00af3c443d1eed772c55bbbf1093071a29bf9a8267f662bbc4618a9c98c3225f501f7fa1cfa958
"@tanstack/react-query": ^5.90.1
react: ^18 || ^19
checksum: 10c0/09e366623a011f322a362f9d646abb5645064db545233398e02ab03b083cb9de27f401ad0594e8b420ad915cdca1971747b3cf3a45201c11167b5554eb24c29c
languageName: node
linkType: hard

Expand Down Expand Up @@ -7192,15 +7187,6 @@ __metadata:
languageName: node
linkType: hard

"copy-anything@npm:^3.0.2":
version: 3.0.5
resolution: "copy-anything@npm:3.0.5"
dependencies:
is-what: "npm:^4.1.8"
checksum: 10c0/01eadd500c7e1db71d32d95a3bfaaedcb839ef891c741f6305ab0461398056133de08f2d1bf4c392b364e7bdb7ce498513896e137a7a183ac2516b065c28a4fe
languageName: node
linkType: hard

"copy-to-clipboard@npm:^3.3.1, copy-to-clipboard@npm:^3.3.3":
version: 3.3.3
resolution: "copy-to-clipboard@npm:3.3.3"
Expand Down Expand Up @@ -9111,7 +9097,7 @@ __metadata:
"@tailwindcss/container-queries": "npm:^0.1.1"
"@tanstack/eslint-plugin-query": "npm:^4.38.0"
"@tanstack/react-query": "npm:^4.29.5"
"@tanstack/react-query-devtools": "npm:^4.29.6"
"@tanstack/react-query-devtools": "npm:^5.90.1"
"@tanstack/react-queryV5": "npm:@tanstack/react-query@^5.59.15"
"@tanstack/react-table": "npm:^8.9.1"
"@tanstack/react-virtual": "npm:^3.13.0"
Expand Down Expand Up @@ -10076,13 +10062,6 @@ __metadata:
languageName: node
linkType: hard

"is-what@npm:^4.1.8":
version: 4.1.16
resolution: "is-what@npm:4.1.16"
checksum: 10c0/611f1947776826dcf85b57cfb7bd3b3ea6f4b94a9c2f551d4a53f653cf0cb9d1e6518846648256d46ee6c91d114b6d09d2ac8a07306f7430c5900f87466aae5b
languageName: node
linkType: hard

"is-wsl@npm:^2.2.0":
version: 2.2.0
resolution: "is-wsl@npm:2.2.0"
Expand Down Expand Up @@ -12886,13 +12865,6 @@ __metadata:
languageName: node
linkType: hard

"remove-accents@npm:0.5.0":
version: 0.5.0
resolution: "remove-accents@npm:0.5.0"
checksum: 10c0/a75321aa1b53d9abe82637115a492770bfe42bb38ed258be748bf6795871202bc8b4badff22013494a7029f5a241057ad8d3f72adf67884dbe15a9e37e87adc4
languageName: node
linkType: hard

"require-directory@npm:^2.1.1":
version: 2.1.1
resolution: "require-directory@npm:2.1.1"
Expand Down Expand Up @@ -13783,15 +13755,6 @@ __metadata:
languageName: node
linkType: hard

"superjson@npm:^1.10.0":
version: 1.13.3
resolution: "superjson@npm:1.13.3"
dependencies:
copy-anything: "npm:^3.0.2"
checksum: 10c0/389a0a0c86884dd0558361af5d6d7f37102b71dda9595a665fe8b39d1ba0e57c859e39a9bd79b6f1fde6f4dcceac49a1c205f248d292744b2a340ee52846efdb
languageName: node
linkType: hard

"supports-color@npm:^5.3.0":
version: 5.5.0
resolution: "supports-color@npm:5.5.0"
Expand Down
Loading