-
Notifications
You must be signed in to change notification settings - Fork 32
[FE2]: ReactUse Import Update #3940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This introduces a tree-shaking performance issue by importing the entire react-use library (~100KB+ of hooks and utilities) instead of only the specific hook needed (useDebounce). Impact: react-use contains 80+ hooks/utilities, but only useDebounce is used in this file. Bundling the entire library significantly increases bundle size unnecessarily. Before (optimized): import { useDebounce } from 'react-use' After (poor tree-shaking): import * as ReactUse from 'react-use'
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3940 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 828 828
Lines 15099 15099
Branches 4326 4326
=======================================
Hits 14891 14891
Misses 200 200
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Bundle ReportBundle size has no change ✅ |
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3940 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 828 828
Lines 15099 15099
Branches 4326 4326
=======================================
Hits 14891 14891
Misses 200 200
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3940 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 828 828
Lines 15099 15099
Branches 4318 4326 +8
=======================================
Hits 14891 14891
Misses 200 200
Partials 8 8
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3940 +/- ##
==========================================
+ Coverage 96.54% 98.62% +2.07%
==========================================
Files 828 828
Lines 15099 15099
Branches 4318 4318
==========================================
+ Hits 14578 14891 +313
+ Misses 466 200 -266
+ Partials 55 8 -47
... and 43 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Modifying ReactUse import
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.