-
Notifications
You must be signed in to change notification settings - Fork 32
[FE6]: Add Memoization to components #3944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3944 +/- ##
==========================================
- Coverage 98.62% 98.51% -0.12%
==========================================
Files 828 829 +1
Lines 15099 15116 +17
Branches 4326 4324 -2
==========================================
Hits 14891 14891
- Misses 200 215 +15
- Partials 8 10 +2
Continue to review full report in Codecov by Sentry.
|
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3944 +/- ##
==========================================
- Coverage 98.62% 98.51% -0.12%
==========================================
Files 828 829 +1
Lines 15099 15116 +17
Branches 4326 4332 +6
==========================================
Hits 14891 14891
- Misses 200 215 +15
- Partials 8 10 +2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3944 +/- ##
==========================================
- Coverage 98.62% 98.51% -0.12%
==========================================
Files 828 829 +1
Lines 15099 15116 +17
Branches 4318 4332 +14
==========================================
Hits 14891 14891
- Misses 200 215 +15
- Partials 8 10 +2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Bundle ReportBundle size has no change ✅ |
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3944 +/- ##
==========================================
+ Coverage 96.54% 98.51% +1.96%
==========================================
Files 828 829 +1
Lines 15099 15116 +17
Branches 4318 4332 +14
==========================================
+ Hits 14578 14891 +313
+ Misses 466 215 -251
+ Partials 55 10 -45
... and 43 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This PR memoizes a bunch of calculations that are needed on the frontend
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.