Clean up ArchiveService
#415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovanni-guidini
approved these changes
Nov 7, 2024
This removes a bunch of unused functions which are not being used by `api`, as well as fix correctly passing the `is_already_gzipped` parameter.
Swatinem
force-pushed
the
swatinem/clean-archive
branch
from
ce68890 to
39615d5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
- Coverage 90.59% 90.02% -0.57%
==========================================
Files 393 324 -69
Lines 11799 9336 -2463
Branches 1975 1671 -304
==========================================
- Hits 10689 8405 -2284
+ Misses 1026 867 -159
+ Partials 84 64 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a bunch of unused functions which are not being used by
api, as well as fix correctly passing theis_already_gzippedparameter.