Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make storage_path nullable on upload #471

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@joseph-sentry joseph-sentry requested a review from a team January 9, 2025 17:28
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (ec85262) to head (e243d39).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   90.34%   89.93%   -0.42%     
==========================================
  Files         429      324     -105     
  Lines       12908     9160    -3748     
  Branches     2108     1630     -478     
==========================================
- Hits        11662     8238    -3424     
+ Misses       1135      859     -276     
+ Partials      111       63      -48     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry force-pushed the joseph/storage-path-null branch from d7d0096 to e243d39 Compare January 16, 2025 16:36
@joseph-sentry joseph-sentry added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 3a2414f Jan 17, 2025
6 checks passed
@joseph-sentry joseph-sentry deleted the joseph/storage-path-null branch January 17, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants