Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USE_MINIO feature flag #477

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Add USE_MINIO feature flag #477

merged 3 commits into from
Jan 16, 2025

Conversation

joseph-sentry
Copy link
Contributor

we want to start by rolling the worker out to use the MinioStorageService for only our repos, then incrementally roll it out to more users

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets do it 💪🏻

@joseph-sentry joseph-sentry added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit ec85262 Jan 16, 2025
6 checks passed
@joseph-sentry joseph-sentry deleted the joseph/use-minio branch January 16, 2025 14:57
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.94%. Comparing base (8607594) to head (67a5024).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   90.32%   89.94%   -0.38%     
==========================================
  Files         429      324     -105     
  Lines       12891     9173    -3718     
  Branches     2106     1631     -475     
==========================================
- Hits        11644     8251    -3393     
+ Misses       1138      859     -279     
+ Partials      109       63      -46     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants