Slightly improve test factories #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whic working on the repo cleanup, I noticed frequent test failures related to `Branch.name` not being unique enough. This fixes that along with some other improvements, like being able to use `CommitWithReportFactory` in `worker` which was not possible previously because of imports that are only valid within `api`.
|
https://github.com/codecov/worker/actions/runs/12828858623/job/35773980100?pr=973 and thats exactly one of those unique constraint failures caused by |
adrian-codecov
approved these changes
Jan 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
- Coverage 90.34% 89.94% -0.41%
==========================================
Files 429 324 -105
Lines 12904 9158 -3746
Branches 2106 1630 -476
==========================================
- Hits 11658 8237 -3421
+ Misses 1135 858 -277
+ Partials 111 63 -48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whic working on the repo cleanup, I noticed frequent test failures related to
Branch.namenot being unique enough. This fixes that along with some other improvements, like being able to useCommitWithReportFactoryinworkerwhich was not possible previously because of imports that are only valid withinapi.