Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add storage_path index on ReportSession #483

Merged
merged 1 commit into from
Jan 28, 2025
Merged

add storage_path index on ReportSession #483

merged 1 commit into from
Jan 28, 2025
+29 −0

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@joseph-sentry joseph-sentry requested a review from a team January 20, 2025 14:59
Swatinem
Swatinem approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this should also help with my deletion code, which uses a IS NULL query on this field to quickly delete all rows without one.

@joseph-sentry joseph-sentry added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@joseph-sentry joseph-sentry added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@joseph-sentry joseph-sentry added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@joseph-sentry joseph-sentry added this pull request to the merge queue Jan 28, 2025
@joseph-sentry joseph-sentry removed this pull request from the merge queue due to a manual request Jan 28, 2025
@joseph-sentry joseph-sentry force-pushed the joseph/add-storage-path-idx branch from 388f9ef to de7616f Compare January 28, 2025 15:31
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@4201051). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage        ?   89.92%           
=======================================
  Files           ?      324           
  Lines           ?     9072           
  Branches        ?     1605           
=======================================
  Hits            ?     8158           
  Misses          ?      851           
  Partials        ?       63

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 854990a Jan 28, 2025
6 checks passed
@joseph-sentry joseph-sentry deleted the joseph/add-storage-path-idx branch January 28, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-sentry @Swatinem