Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make plan non-nullable and drop plan type #533

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ajay-sentry
Copy link
Contributor

This PR is an extension of codecov/worker#1103, closing the loop on plan type thats nullable as well as removing the default value for the plan which was a plan name we don't want to support anymore.

This will hopefully prevent others from falling into the same pitfall we did

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #533 will create unknown performance changes

Comparing Ajay/drop-nullable-plan-and-default-type (c171275) with main (47fa7fd)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.\

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending confirmation if these should be risky changes and what is the effect from making a plan non-nullable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants