Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove testrun pyi file #1012

Merged
merged 1 commit into from
Jan 17, 2025
Merged

remove testrun pyi file #1012

merged 1 commit into from
Jan 17, 2025

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@joseph-sentry joseph-sentry requested a review from a team January 16, 2025 21:35
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (2c7bd18) to head (5a539b2).
Report is 7 commits behind head on main.

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
+ Coverage   97.74%   97.75%   +0.01%     
==========================================
  Files         451      451              
  Lines       36670    36812     +142     
==========================================
+ Hits        35843    35986     +143     
+ Misses        827      826       -1     
Flag Coverage Δ
integration 42.48% <ø> (-0.09%) ⬇️
unit 90.22% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason being that the actual .py file exists, so there is no need to keep the .pyi file around?

@joseph-sentry
Copy link
Contributor Author

the reason being that the actual .py file exists, so there is no need to keep the .pyi file around?

@Swatinem the reason is that it was breaking the pre-commit linting (not the actual linting). This is meant to be a temporary change until i get this working with the pre-commit linting.

@joseph-sentry joseph-sentry added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 6e48b6a Jan 17, 2025
27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/remove-testrun-pyi branch January 17, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants