Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test analytics #1016

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix test analytics #1016

wants to merge 2 commits into from

Conversation

joseph-sentry
Copy link
Contributor

  • removes functions we don't use anymore
  • fixes the insert on conflict condition to be test_id instead of the previous set of fields when inserting tests in the new TA processor
  • adds a log to help debug when we're rewriting readable reports in TA

@joseph-sentry joseph-sentry requested a review from a team January 17, 2025 19:03
Copy link

sentry-io bot commented Jan 17, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: tasks/test_results_processor.py

Function Unhandled Issue
process_individual_upload FileNotInStorageError: File test_results/v1/raw/github/getsentry::::sentry-javascript/2bc35842322a021af642969cf4fcb60b22... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (72f2512) to head (48ef1aa).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1016      +/-   ##
==========================================
+ Coverage   97.76%   97.78%   +0.02%     
==========================================
  Files         451      451              
  Lines       36798    36913     +115     
==========================================
+ Hits        35974    36095     +121     
+ Misses        824      818       -6     
Flag Coverage Δ
integration 42.45% <60.00%> (-0.03%) ⬇️
unit 90.27% <60.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant