Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: include migrating timeseries #1168

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joseph-sentry
Copy link
Contributor

Follow up to: #1167

we previously did not include timeseries in INSTALLED_APPS
and we did not include it in the migrate-timeseries.sh script

but there's no good reason for that, and we should try to migrate
all apps and databases if we can

i think monorepo fixes this in some way but for now we should do this
and when we move over to the monorepo we should take a second look
at all these different scripts and try to consolidate the logic

@joseph-sentry joseph-sentry force-pushed the joseph/update-timeseries branch from 87b53c3 to 63614a8 Compare March 21, 2025 20:32
Copy link

✅ Sentry found no issues in your recent changes ✅

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 97.72%. Comparing base (87f463e) to head (63614a8).
Report is 3 commits behind head on main.

Current head 63614a8 differs from pull request most recent head 38511a9

Please upload reports for the commit 38511a9 to get more accurate results.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
migrate_timeseries.py 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
- Coverage   97.77%   97.72%   -0.06%     
==========================================
  Files         448      449       +1     
  Lines       36823    36866      +43     
==========================================
+ Hits        36004    36026      +22     
- Misses        819      840      +21     
Flag Coverage Δ
integration 42.89% <0.00%> (+0.02%) ⬆️
unit 90.41% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
migrate_timeseries.py 0.00% 20 Missing ⚠️

📢 Thoughts on this report? Let us know!

we previously did not include timeseries in INSTALLED_APPS
and we did not include it in the migrate-timeseries.sh script

but there's no good reason for that, and we should try to migrate
all apps and databases if we can

i think monorepo fixes this in some way but for now we should do this
and when we move over to the monorepo we should take a second look
at all these different scripts and try to consolidate the logic
@joseph-sentry joseph-sentry force-pushed the joseph/update-timeseries branch from 63614a8 to 38511a9 Compare March 21, 2025 20:53
Copy link
Contributor

@matt-codecov matt-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if nothing is broken deploy next week since it's late on friday

@joseph-sentry joseph-sentry marked this pull request as ready for review March 24, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants