-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: include migrating timeseries #1168
base: main
Are you sure you want to change the base?
Conversation
87b53c3
to
63614a8
Compare
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1168 +/- ##
==========================================
- Coverage 97.77% 97.72% -0.06%
==========================================
Files 448 449 +1
Lines 36823 36866 +43
==========================================
+ Hits 36004 36026 +22
- Misses 819 840 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
we previously did not include timeseries in INSTALLED_APPS and we did not include it in the migrate-timeseries.sh script but there's no good reason for that, and we should try to migrate all apps and databases if we can i think monorepo fixes this in some way but for now we should do this and when we move over to the monorepo we should take a second look at all these different scripts and try to consolidate the logic
63614a8
to
38511a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if nothing is broken deploy next week since it's late on friday
Follow up to: #1167
we previously did not include timeseries in INSTALLED_APPS
and we did not include it in the migrate-timeseries.sh script
but there's no good reason for that, and we should try to migrate
all apps and databases if we can
i think monorepo fixes this in some way but for now we should do this
and when we move over to the monorepo we should take a second look
at all these different scripts and try to consolidate the logic