Skip to content

Conversation

@TropicolX
Copy link
Contributor

@TropicolX TropicolX commented Oct 30, 2025

Removed placeholder text and updated instructions for the ApiVersions stage.


Note

Expands stage_descriptions/base-05-pv1.md with a detailed ApiVersions v4 response spec, example hex, test command, and validation criteria (including message_size).

  • Docs (stage_descriptions/base-05-pv1.md):
    • Add recap of the ApiVersions API with links to request/response inspectors.
    • Specify v4 response body structure, including error_code, api_keys (compact array with tagged fields), throttle_time_ms.
    • Require entry for API key 18 with min_version 0 and max_version 4.
    • Provide example hex-encoded response and emphasize correct message_size calculation.
    • Add test instructions: command to send a sample request, breakdown of request header, and response validation checks (matching correlation ID, error_code 0, required API key entry, no trailing bytes).
    • Clarify notes: tester uses v4 and validates the first 4 bytes (message_size).

Written by Cursor Bugbot for commit ecb282a. This will update automatically on new commits. Configure here.

Removed placeholder text and updated instructions for the ApiVersions stage.
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

LLM Doc Lint

13 tests   10 ✅  0s ⏱️
 1 suites   0 💤
 1 files     3 ❌

For more details on these failures, see this check.

Results for commit 11655fb.

♻️ This comment has been updated with latest results.

Expanded the documentation for the ApiVersions API, detailing the response structure and validation requirements.
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

LLM Doc Lint

13 tests   12 ✅  0s ⏱️
 1 suites   0 💤
 1 files     1 ❌

For more details on these failures, see this check.

Results for commit 3004792.

♻️ This comment has been updated with latest results.

Clarify validation criteria for the tester's response.
@TropicolX TropicolX marked this pull request as ready for review October 31, 2025 12:00
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

LLM Doc Lint

13 tests   13 ✅  0s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 8d81451.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

LLM Doc Lint

13 tests   13 ✅  0s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit ecb282a.

♻️ This comment has been updated with latest results.

@TropicolX TropicolX merged commit d5a5155 into main Oct 31, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants