-
Notifications
You must be signed in to change notification settings - Fork 9
[#qm8] Change bell char from \a
to \x07
#88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Include guidance for using '\u0007' as an alternative to '\a' for languages that do not support the latter in the shell completion section.
Caution Review failedThe pull request is closed. WalkthroughTrailing colons were removed from the "Notes" section headers in the "Builtin completion" and "Missing completions" stages of the shell course definition YAML. Additionally, the bell character description in the "Missing completions" note was updated from Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
course-definition.yml (1)
1051-1054
: Ensure consistent formatting of the “Notes” headingThe new “### Notes:” heading includes a trailing colon, but all other stages use “### Notes” (no colon). To keep consistency, update it as follows and remove the extra blank line before the list item:
- ### Notes: - - - If `\a` is not supported in the language you're using, you can use `\u0007` instead. + ### Notes + - If `\a` is not supported in the language you're using, you can use `\u0007` instead.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
course-definition.yml
(1 hunks)
Removed unnecessary line breaks in the notes sections for shell completion and bell character guidance to improve readability and maintain a uniform format.
\a
to \x07
Replaced the mention of '\a' with '\x07' for clarity and added a link to the bell character Wikipedia page for better understanding. This change enhances the accuracy of the instructions regarding handling invalid commands in the shell.
Thanks @Unsleeping for highlighting the issue! |
Multiple users have highlighted that \a does not work in Java, JS and TS.
Summary by CodeRabbit