Skip to content

[#qm8] Change bell char from \a to \x07 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025
Merged

[#qm8] Change bell char from \a to \x07 #88

merged 3 commits into from
May 20, 2025

Conversation

andy1li
Copy link
Member

@andy1li andy1li commented May 19, 2025

Multiple users have highlighted that \a does not work in Java, JS and TS.

Summary by CodeRabbit

  • Documentation
    • Updated the course description to clarify alternatives for producing the bell sound in the "Missing completions" stage.
    • Improved formatting by removing trailing colons from "Notes" section headers in two course stages.
    • Added a link to the bell character Wikipedia page for additional reference.

Include guidance for using '\u0007' as an alternative to '\a' for languages that do not support the latter in the shell completion section.
@andy1li andy1li requested a review from rohitpaulk May 19, 2025 03:15
@andy1li andy1li self-assigned this May 19, 2025
Copy link

coderabbitai bot commented May 19, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Trailing colons were removed from the "Notes" section headers in the "Builtin completion" and "Missing completions" stages of the shell course definition YAML. Additionally, the bell character description in the "Missing completions" note was updated from \a to \x07 with a hyperlink to the bell character Wikipedia page.

Changes

File(s) Change Summary
course-definition.yml Removed trailing colons from "Notes" headers; updated bell character escape sequence from \a to \x07 with a Wikipedia link in "Missing completions" note

Poem

In the shell course, a note now rings,
About bells and the sound it brings.
If \a won’t play, don’t you fret,
\x07 is the backup you’ll get!
With every beep, the lesson’s clear—
Even in code, the bell we hear!
🐰🔔

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 58ff7b0 and 615f140.

📒 Files selected for processing (1)
  • course-definition.yml (2 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
course-definition.yml (1)

1051-1054: Ensure consistent formatting of the “Notes” heading

The new “### Notes:” heading includes a trailing colon, but all other stages use “### Notes” (no colon). To keep consistency, update it as follows and remove the extra blank line before the list item:

-      ### Notes:
-
-      - If `\a` is not supported in the language you're using, you can use `\u0007` instead.
+      ### Notes
+      - If `\a` is not supported in the language you're using, you can use `\u0007` instead.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 24ed5c8 and 797e801.

📒 Files selected for processing (1)
  • course-definition.yml (1 hunks)

Removed unnecessary line breaks in the notes sections for shell completion and bell character guidance to improve readability and maintain a uniform format.
@andy1li andy1li changed the title [#qm8] Add note on alternative bell character in instructions [#qm8] Change bell char from \a to \x07 May 20, 2025
Replaced the mention of '\a' with '\x07' for clarity and added a link to the bell character Wikipedia page for better understanding. This change enhances the accuracy of the instructions regarding handling invalid commands in the shell.
@andy1li andy1li merged commit eef1fc6 into main May 20, 2025
26 of 27 checks passed
@andy1li
Copy link
Member Author

andy1li commented May 21, 2025

Thanks @Unsleeping for highlighting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants