feat(billing): add membership renewal extension flow#3555
Merged
rohitpaulk merged 3 commits intomainfrom Jan 10, 2026
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Test Results 1 files ±0 1 suites ±0 6m 47s ⏱️ -6s For more details on these errors, see this check. Results for commit 0c1ef76. ± Comparison against base commit 8d5325a. ♻️ This comment has been updated with latest results. |
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
rohitpaulk
force-pushed
the
feat-membership-renewal-extension
branch
from
a949f98 to
a70b876
Compare
Bundle ReportChanges will decrease total bundle size by 229.63kB (-0.59%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
Files in
|
rohitpaulk
force-pushed
the
feat-membership-renewal-extension
branch
from
a70b876 to
b55c244
Compare
rohitpaulk
force-pushed
the
feat-membership-renewal-extension
branch
2 times, most recently
from
a8696f0 to
0c104c9
Compare
rohitpaulk
force-pushed
the
feat-membership-renewal-extension
branch
from
0c104c9 to
1e27abb
Compare
rohitpaulk
force-pushed
the
feat-membership-renewal-extension
branch
from
1e27abb to
7473fc7
Compare
rohitpaulk
force-pushed
the
feat-membership-renewal-extension
branch
from
7473fc7 to
ba01b36
Compare
rohitpaulk
force-pushed
the
feat-membership-renewal-extension
branch
2 times, most recently
from
2020a6e to
ac9817f
Compare
rohitpaulk
force-pushed
the
feat-membership-renewal-extension
branch
from
ac9817f to
e07ced6
Compare
rohitpaulk
force-pushed
the
feat-membership-renewal-extension
branch
from
e07ced6 to
1576702
Compare
|
|
||
| Args: { | ||
| onExtendMembershipButtonClick: () => void; | ||
| subscription: SubscriptionModel; |
There was a problem hiding this comment.
Unused subscription argument indicates incomplete conditional logic
Medium Severity
The subscription argument is declared as required in the component signature and is passed from billing.hbs, but it's never used in the RenewalSection component. The PR description mentions implementing a canBeExtended getter and conditionally enabling the button with a tooltip showing the earliest extension date, but none of this logic exists. The "Extend membership" button is always enabled regardless of subscription state, which may allow users to attempt extensions outside the intended 45-day window mentioned in the PR description.
Additional Locations (1)
rohitpaulk
force-pushed
the
feat-membership-renewal-extension
branch
from
1576702 to
4bd3ddf
Compare
rohitpaulk
force-pushed
the
feat-membership-renewal-extension
branch
from
4bd3ddf to
5ac4455
Compare
rohitpaulk
force-pushed
the
feat-membership-renewal-extension
branch
2 times, most recently
from
0845c82 to
3e6eed9
Compare
Add ability to extend active subscriptions within 45 days of expiry by introducing `canBeExtended` getter on Subscription model. Update renewal section to reflect membership renewal status and conditionally enable the extend membership button with tooltip showing the earliest extension date. Pass active subscription to renewal section and handle button click action.
Co-authored-by: rohitpaulk <rohitpaulk@gmail.com>
rohitpaulk
force-pushed
the
feat-membership-renewal-extension
branch
from
71f76ed to
0c1ef76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to extend active subscriptions within 45 days of expiry by
introducing
canBeExtendedgetter on Subscription model. Update renewalsection to reflect membership renewal status and conditionally enable the
extend membership button with tooltip showing the earliest extension date.
Pass active subscription to renewal section and handle button click action.
Note
Introduces an extend-membership flow on the Billing page and related UX tweaks.
RenewalSectionUI with explanatory text and an "Extend membership" button that opensChooseMembershipPlanModal/settings/billingcancel,/settings/billing?action=membership_extendedsuccess) and loadsregionalDiscount?action=membership_extendedand clears the query paramsubscription.isLifetimeMembershipand hides renewal section when no active subscription or lifetime membershipsettings/billing) to manage modal state, query param, success notice, and discount loadingWritten by Cursor Bugbot for commit 0c1ef76. This will update automatically on new commits. Configure here.