feat(course-setup): add CLI ping step controlled by feature flag#3571
Merged
Conversation
Test Results 1 files ±0 1 suites ±0 6m 40s ⏱️ -3s For more details on these errors, see this check. Results for commit d3c2ded. ± Comparison against base commit 6efff22. This pull request removes 7 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
❌ 6 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
rohitpaulk
force-pushed
the
feat-cli-ping-step-feature-flag
branch
from
ef2523d to
098c2b6
Compare
Bundle ReportChanges will decrease total bundle size by 230.44kB (-0.59%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
Files in
Files in
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| {{! TODO: Change troubleshooting link }} | ||
| <span class="text-blue-500 text-xs underline font-medium"> | ||
| <a href="#" {{on "click" (fn (mut this.isCommitModalOpen) true)}}>Troubleshoot</a> |
There was a problem hiding this comment.
CLI troubleshoot link opens git commit modal
When canViewCLIPingFlow is enabled, the Troubleshoot link opens isCommitModalOpen, which displays git commit troubleshooting instructions (like running git commit -am "[any message]" and resolving "nothing to commit" issues). This is incorrect for users running codecrafters test since the modal content is completely irrelevant to CLI troubleshooting. Users will see confusing git instructions when they need help with the CLI command.
rohitpaulk
force-pushed
the
feat-cli-ping-step-feature-flag
branch
2 times, most recently
from
a55252d to
e5b52b6
Compare
rohitpaulk
force-pushed
the
feat-cli-ping-step-feature-flag
branch
from
e5b52b6 to
c73ca46
Compare
Introduce a new "Test CLI connection" setup step that replaces the previous "Push empty commit" step when the `canViewCLIPingFlow` feature flag is enabled. Update related UI text and instructions to reflect this new flow, including the addition of a reusable command component for running CLI connection tests. This change enables a smoother onboarding experience for users with access to experimental CLI ping functionality, controlled via a feature flag to allow gradual rollout without impacting existing users.
rohitpaulk
force-pushed
the
feat-cli-ping-step-feature-flag
branch
from
c73ca46 to
d3c2ded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new "Test CLI connection" setup step that replaces the
previous "Push empty commit" step when the
canViewCLIPingFlowfeature flag is enabled. Update related UI text and instructions to
reflect this new flow, including the addition of a reusable command
component for running CLI connection tests.
This change enables a smoother onboarding experience for users with
access to experimental CLI ping functionality, controlled via a
feature flag to allow gradual rollout without impacting existing users.
Note
Enables an alternative CLI-driven onboarding flow when
can-view-cli-ping-flowis active.featureFlags.canViewCLIPingFlowand routes setup/test runner UX accordinglypush-empty-commit→test-cli-connection(new component) under flag; adds Troubleshooting modal and links to clone/push/test stepsRun tests(CLI) vsGit pushinstructions conditionally; submit step supportscodecrafters testListening for ping.../Ping received.when flaggedWritten by Cursor Bugbot for commit d3c2ded. This will update automatically on new commits. Configure here.