Skip to content

Commit 2e6241e

Browse files
committed
2.x: Fixed typo
1 parent a775d9a commit 2e6241e

File tree

2 files changed

+12
-24
lines changed

2 files changed

+12
-24
lines changed

.github/workflows/README.md

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,25 @@
11
# GitHub Actions
22
This document describes the current CI for the ce-dev project. The CI is written for GitHub Actions, the built in GitHub system for orchestration and automation. We operate three separate GitHub Actions workflows.
33

4-
## ce-dev-build-dev
5-
Builds base and controller images using the contents of the `devel` branch on push. The built images get pushed to Docker Hub and tagged with `devel`. This is very useful for pushing test containers to try out locally.
4+
### devel-ubuntu-linux.yml
65

7-
### Testing project images
6+
Linux - Build binaries, images and templates using devel mode.
7+
8+
### ubuntu-linux.yml
9+
10+
Linux - Build binaries, images and templates. Docker images are pushed. New release is created.
11+
12+
# Testing project images
813
To test a `devel` container on a project, firstly fetch the container image:
914

1015
```
1116
docker pull codeenigma/ce-dev-controller:2.x
1217
```
1318

14-
Then edit your project's `ce-dev.compose.yml` file, changing the image for each applicable service to use the `devel` tag instead of the `latest` tag, for example:
19+
Then edit your project's `ce-dev.compose.yml` file, changing the image for each applicable service to use the `-devel` tag instead of the current tag, for example:
1520

1621
```yaml
17-
image: codeenigma/ce-dev:2.x
22+
image: codeenigma/ce-dev:2.x -> image: codeenigma/ce-dev:2.x-devel
1823
```
1924
2025
Finally, destroy and recreate your `docker compose` file and containers:
@@ -51,24 +56,7 @@ git merge origin my_test_branch
5156

5257
Then use `ce-dev provision` and `ce-dev deploy` in the usual way.
5358

54-
### Known issues
55-
* The golang release needs keeping up to date (there's no 'latest' download we can use)
56-
* `mkcert` is built from source, initially because of a bad release but now it's like that we might as well keep it that way
57-
58-
## ce-dev-build
59-
This builds the images and binaries, pushes the Docker containers to Docker Hub, pushes the binaries to a GitHub release and builds and commits the ce-dev documentation. It runs when someone accepts a PR for or pushes to the `2.x` branch and has added a valid tag in the format `2.*`. These images are tagged `latest` in the Docker repository.
60-
6159
### Known issues
6260
* The golang release needs keeping up to date (there's no 'latest' download we can use)
6361
* `mkcert` is built from source, initially because of a bad release but now it's like that we might as well keep it that way
6462
* If we start developing in a new version branch we will need to update the `on: push:` YAML in this workflow to allow the new tags or it won't execute
65-
66-
## ce-dev-lint
67-
This runs ESLint over the JavaScript code in the `src` directory. It runs on every pull request. It uses the ESLint config defined in `./.eslintrc` so if you need to change its behaviour, edit that file.
68-
69-
## ce-dev-test
70-
This builds the images and tests the ce-dev stack. It runs on every pull request and daily at 6:30.
71-
72-
### Known issues
73-
* The golang release needs keeping up to date (there's no 'latest' download we can use)
74-
* `mkcert` is built from source, initially because of a bad release but now it's like that we might as well keep it that way

src/controller-manager.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ export default class ControllerManager {
250250
// If in development mode, we use devel version.
251251
let version = AppSettings.ceDevVersion + '.x';
252252
if (this.developmentMode) {
253-
version = '-devel';
253+
version += '-devel';
254254
}
255255
execSync(this.dockerBin + ' pull codeenigma/ce-dev-controller:' + version, {
256256
stdio: 'inherit',
@@ -261,7 +261,7 @@ export default class ControllerManager {
261261
const ipManager = new IPManager(this.config, this.dockerBin)
262262
let version = AppSettings.ceDevVersion + '.x'
263263
if (this.developmentMode) {
264-
version = '-devel'
264+
version += '-devel'
265265
}
266266
return {
267267
networks: {

0 commit comments

Comments
 (0)