-
Notifications
You must be signed in to change notification settings - Fork 7
Asap 221 migrate off preview model #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4dh
approved these changes
Sep 15, 2025
4dh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge- seeing gemini-2.5-pro, as expected (thanks for your help!) and the inference time is generally in line with your testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception check is currently using gemini-2.5-pro-preview-03-25. We should investigate some other models and try to get off the preview.
This PR adds the following:
gemini-flash-2.0togemini-flash-2.5.gemini-2.5-pro-preview-03-25togemini-2.5-proEvaluation
The following two dashboards were used in assessing evaluation results:
Evaluation Results: Summary
The summarization process is currently using
gemini-flash-2.0. It seems reasonable that the 2.0 family of models will eventually be discontinued. This seemed like a reasonable moment to compare a few other options. I tried running a evaluation of summaries created bygemini-flash-2.5andgemini-flash-lite-2.5.Baseline Values (52e7441, ~200 samples):
Rouge Mean: 0.38100022576030146
LLM Summarization Mean: 0.23819095477386934
Given the speed and metric changes,
gemini-flash-2.5seems like a safe move for summarization. The drop in rouge score and increase in llm summarization metric essentially wash out. This change may be random, though ttest values suggest otherwise. It may also be related to increased reasoning capacity in the model, allowing summarization with less direct regurgitation.I wanted to try gpt-5-mini for summarization, but was having issues running the summarization metric with output from gpt-5-mini. This could have been severe rate limiting by Google. The summarization metric does make at least four LLM calls per document. Here is a ticket to explore and possibly replace this approach.
Evaluation Results: Exception Check
The evaluation process is currently using the
gemini-2.5-pro-preview-03-25model, which feels like it could be discontinued at any time. I tried running evaluation exception checks withgemini-pro-2.5andgpt-5with default the reasoning setting.Baseline Values (b7fee4e, ~200 samples):
Overall accuracy: 98.1%
Exception accuracy: 33%
Archival accuracy: 81.5%
Here is an atomic breakdown of the metrics comparing the two Gemini models:
Given the relatively small change in overall accuracy and the individual metrics, changing from
gemini-2.5-pro-preview-03-25togemini-pro-2.5seems safe. The relatively big drop off in gpt-5 is hard to explain and would probably require more digging around. For now, sticking with Gemini probably makes the most sense.What additional steps are required to test this branch locally?
Rebuild the images
docker-compose build --no-cache.Are there any areas you would like extra review?
The above evaluation results.
No