Correct the internal URL shape: per-app subdomain, no path prefix - #14
Merged
Conversation
Reading the shared-services-infra static-app layer shows each app is served at the root of its own subdomain — the layer's endpoint_url output is https://<name>.apps.<domain> and a CloudFront edge function maps the subdomain to the app's S3 prefix behind the scenes. The workflow no longer derives PATH_PREFIX from STATIC_PREFIX (which would double-prefix every internal link), and the guide and README now describe SITE_URL as the endpoint URL and STATIC_PREFIX as the S3 slot only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While preparing the
shared-services-infraregistration PR for this app, I read the platform'sstatic-applayer and found our earlier URL assumption was wrong:endpoint_urloutput ishttps://<name>.apps.<domain>— each app is served at the root of its own subdomainThat means the internal build must not set
PATH_PREFIX: the previous workflow derivedPATH_PREFIX: //from the S3 slot, which would have double-prefixed every internal link, image, and Pagefind path.Changes:
sharedservices-deploy.yaml: build step no longer setsPATH_PREFIX(left unset → defaults to/); header comments updated to describeSITE_URLas the app's endpoint URL andSTATIC_PREFIXas the S3 slot onlydocs/devops-sharedservices-setup.html: step 1 now asks DevOps for four hand-back values (adds theendpoint_url), the callout explains subdomain + edge-rewrite serving, the step 2 table rows forSTATIC_PREFIX/SITE_URLand step 3–4 texts correctedVerification: precommit gate green.