Skip to content

Conversation

@jamesiarmes
Copy link
Member

No description provided.

@jamesiarmes jamesiarmes requested a review from Copilot October 8, 2025 18:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Application Load Balancer (ALB) origins to the CloudFront WAF module, allowing users to specify an ALB ARN instead of a domain name for the origin configuration.

  • Introduces origin_alb_arn variable to accept ALB ARN as an alternative to domain-based origins
  • Updates origin domain resolution logic to use ALB DNS name when ALB ARN is provided
  • Adds certificate attachment to ALB listener for proper TLS negotiation with CloudFront

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
variables.tf Adds new origin_alb_arn variable for ALB support
locals.tf Updates origin domain logic to use ALB DNS name when ALB ARN is provided
data.tf Adds data sources for ALB and listener information
dns.tf Adds certificate attachment to ALB listener
README.md Updates documentation and version references to 1.10.0
.github/workflows/branch.yaml Fixes typo in workflow step name
trivy.yaml Pins trivy-checks version to 1.11 with explanatory comment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jamesiarmes jamesiarmes merged commit 719087d into main Oct 8, 2025
4 checks passed
@jamesiarmes jamesiarmes deleted the alb-origin branch October 8, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants