Fyst 971 pull household information directly from df json

[mrotondo]

Link to pivotal/JIRA issue

• https://codeforamerica.atlassian.net/browse/FYST-971
• https://codeforamerica.atlassian.net/browse/FYST-989

Is PM acceptance required? (delete one)

• Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

• Removed the NameDob controller/form/view
• Pull in the "months in home" value from the DF JSON into StateFileDependent.months_in_home, and handle the fact that we will only get values of 6 and up (or null) in that JSON field
• Changed all our uses of StateFileDependent.relationship to use the new non-gendered relationship names that we pull in from the DF JSON
• Removed "edit" link from household info on the review page
• Changed the default EfileError controller to DataReview, which is the page immediately after DF import. I don't love this, but I don't know of a better option. I've asked PM to weigh in on the story
• Updated many many tests to account for the above changes (different relationship names, use DF JSONs instead of specifying name/dob/months in home in test config, don't expect to see the NameDob page in feature tests, etc)

How to test?

• Ensure that the NameDob page doesn't show up in any state flows
• Ensure that (when you use a persona that has a JSON set up) all filer & dependent info from that JSON is used correctly in our output XML & PDF. You can see which persona have JSONs by looking inhttps://github.com/codeforamerica/vita-min/tree/FYST-971-pull-household-information-directly-from-df-json/spec/fixtures/state_file/fed_return_jsons/2023

[github-actions]

Heroku app: https://gyr-review-app-4970-3d1519ebed7d.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4970 (optionally add --tail)

[mpidcock]

I'm just passing through, but pls fill out the PR template and address failing tests 🙏

[anisharamnani]

🎉 i don't have any feedback. things look good & i appreciate that the tests have been updated to reflect the new way of pulling household information. thanks @mrotondo :)

[arinchoi03]

real quick review as i'm working off of spotty internet but i promised some comments so here are some! nothing blocking i think