Move initial efile device collection to income review page

[embarnard]

Link to pivotal/JIRA issue

https://codeforamerica.atlassian.net/browse/FYST-1193?atlOrigin=eyJpIjoiODYzMzAzN2ViODEzNDNiNWE3YWM4ZGMzYTBkMTM0YjIiLCJwIjoiaiJ9

Is PM acceptance required? (delete one)

• Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

• We now redirect away from the data review page, moved efile device id collection to the income review page
• Initially we tried changing the hidden button on the waiting to load page to submit the device id but this proved risky so opted for taking another approach
• The data review page still exists but only for non-prod environments since we needed a page that would hold that edit DF XML button in testing environments

How to test?

• Test that AZ, ID, MD, NC and NJ all skip the data review page and that we still have have these fields filled out in the xml auth header:

xml.TransmissionDetail do
          xml.InitialCreation do
            xml.IPAddress do
              xml.IPv4AddressTxt 
              xml.IPv6AddressTxt 
            end
            xml.IPTs 
            xml.DeviceId 
            xml.DeviceTypeCd 
          end
end

[github-actions]

Heroku app: https://gyr-review-app-5029-0fb8eede6440.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5029 (optionally add --tail)

[anisharamnani]

[dust] 🤔 since this page is now only going to be visible to those on non-prod environments, it might be helpful to see that in the label. For example "This page is only visible on development" The current description is more filer saving.

[anisharamnani]

[pebble] removing these expectations leaves the test in a weird state. the last line in each of these tests is clicking on "Continue." I think it would be preferable to have an expectation.

Is there an expectation that can be added here after clicking on continue? Possibly testing that the SSN is being added to the DB?

[anisharamnani]

i've got two comments. one pebble & dust. otherwise this looks good! thanks @embarnard!