Skip to content

FYST-450 Fix nc subtractions page limit #5066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tahsinaislam merged 3 commits into from
Dec 4, 2024
Merged

FYST-450 Fix nc subtractions page limit #5066

tahsinaislam merged 3 commits into from
Dec 4, 2024

Conversation

@tahsinaislam
Copy link
Contributor

@tahsinaislam tahsinaislam commented Dec 3, 2024

Link to pivotal/JIRA issue

https://codeforamerica.atlassian.net/browse/FYST-450

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

What was done?

  • Add a methods to the D400 calculator to be able to calculate the right limit for NC subtractions. This method was then added to the controller and form for NC subtractions in order to put the limit on the view and also have the correct error message is the limit is exceeded.

How to test?

  • Unit test was updated to reflect the right limit

Screenshots (for visual changes)

  • Before
Screenshot 2024-12-02 at 4 58 07 PM - After Screenshot 2024-12-02 at 4 57 45 PM

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

Heroku app: https://gyr-review-app-5066-4d81d648fbb9.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5066 (optionally add --tail)

@tahsinaislam tahsinaislam marked this pull request as ready for review December 3, 2024 01:07
@tahsinaislam tahsinaislam force-pushed the FYST-1241-nc-federally-recognized-indian-tribe-subtraction-not-calculating-correctly branch from 05ab69d to 592b074 Compare December 3, 2024 17:17
squanto
squanto approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@squanto squanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@tahsinaislam tahsinaislam merged commit 6c18465 into main Dec 4, 2024
4 checks passed
@tahsinaislam tahsinaislam deleted the FYST-1241-nc-federally-recognized-indian-tribe-subtraction-not-calculating-correctly branch December 4, 2024 00:19
tahsinaislam added a commit that referenced this pull request Dec 4, 2024
@tahsinaislam
Revert "FYST-450 Fix nc subtractions page limit (#5066)"
043e672 
This reverts commit 6c18465.
@tahsinaislam tahsinaislam mentioned this pull request Dec 4, 2024
Merged
@tahsinaislam tahsinaislam restored the FYST-1241-nc-federally-recognized-indian-tribe-subtraction-not-calculating-correctly branch December 4, 2024 00:43
@tahsinaislam tahsinaislam deleted the FYST-1241-nc-federally-recognized-indian-tribe-subtraction-not-calculating-correctly branch December 4, 2024 00:44
tahsinaislam added a commit that referenced this pull request Dec 4, 2024
@tahsinaislam
Revert "FYST-450 Fix nc subtractions page limit (#5066)" (#5086)
9b9d72a 
This reverts commit 6c18465.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@squanto squanto squanto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tahsinaislam @squanto