[FYST-1242] Disable edit/review of NC Income Docs #5074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 3, 2024 10:43
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
|
Heroku app: https://gyr-review-app-5074-b23819b9b315.herokuapp.com/ |
added 5 commits
December 3, 2024 11:22
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
tahsinaislam
approved these changes
Dec 3, 2024
powersurge360
approved these changes
Dec 3, 2024
Contributor
powersurge360
left a comment
powersurge360
left a comment
There was a problem hiding this comment.
Didn't thoroughly review but was asked for opinion on headers and that part at least looks good!
Co-authored-by: Hugo Melo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
What was done?
return_to_reviewurl param, to redirect nc intakes back to reviewreview_headerto nc to update income sectionHow to test?