Fyst 1517 add ssn itin validation step to prior year access flow #5326

anisharamnani · 2025-01-08T20:07:14Z

Link to pivotal/JIRA issue

https://codeforamerica.atlassian.net/browse/FYST-1517

Is PM acceptance required? (delete one)

Yes - don't merge until JIRA issue is accepted!

What was done?

Added ssn page verification
Added validations to check for existing archived intakes with matching ssn and email address
Added in the conditions for allowing access to the ssn page which includes checking in the session that the code was verified in the previous screen and checking that the request has not already been locked out

How to test?

Add units tests for the new form and controller
Updated verification code controller spec for adding condition to check if code was verified before accessing the identification number page
Added to the feature spec

Screenshots (for visual changes)

After

Co-authored-by: Drew Proebstel <[email protected]>

…" (#5317) This reverts commit f1e5246. Co-authored-by: Drew Proebstel <[email protected]>

… into FYST-1516-add-email-validation-step-to-prior-year-access-flow

…access-mvp

* Add last year verification email Co-authored-by: Em Barnard-Shao <[email protected]> Co-authored-by: Hugo Melo <[email protected]> * Rename previous year to archived intake Co-authored-by: Hugo Melo <[email protected]> * normalize Co-authored-by: Hugo Melo <[email protected]> --------- Co-authored-by: Em Barnard-Shao <[email protected]>

…il-validation-step-to-prior-year-access-flow

github-actions · 2025-01-08T20:12:07Z

Heroku app: https://gyr-review-app-5326-483eb329f5d0.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5326 (optionally add --tail)

anisharamnani · 2025-01-15T19:22:02Z

app/forms/state_file/completed_return_email_address_controller.rb

+module StateFile
+  class CompletedReturnEmailAddressForm < QuestionsForm
+
+  end


we have to delete this too.

anisharamnani · 2025-01-15T19:23:11Z

app/lib/navigation/completed_tax_return_navigation.rb

@@ -0,0 +1,12 @@
+module Navigation
+  class CompletedTaxReturnNavigation < Navigation::StateFileBaseQuestionNavigation


we also must delete this.

anisharamnani · 2025-01-15T19:24:31Z

app/views/state_file/questions/validate_identification_number/edit.html.erb

@@ -0,0 +1,2 @@
+<% content_for :page_title, t(".title") do %>


i think we delete this tooo.

anisharamnani · 2025-01-15T19:25:10Z

db/data/20241226211010_add_address_to_completed_2023_tax_return.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true


bye bye bye

anisharamnani · 2025-01-15T19:26:11Z

spec/support/helpers/state_file_intake_helper.rb

@@ -92,7 +92,7 @@ def step_through_initial_authentication(contact_preference: :text_message)
      expect(page).to have_text "Enter your email address"
      fill_in I18n.t("state_file.questions.email_address.edit.email_address_label"), with: "[email protected]"
      click_on "Send code"
-
+      save_and_open_page


…ior-year-access-flow Co-authored-by: Anisha Ramnani <[email protected]>

Co-authored-by: Anisha Ramnani <[email protected]>

Co-authored-by: Tahsina Islam <[email protected]>

…n-validation-step-to-prior-year-access-flow Co-authored-by: Tahsina Islam <[email protected]>

Co-authored-by: Anisha Ramnani <[email protected]>

…ior-year-access-flow Co-authored-by: Anisha Ramnani <[email protected]>

Co-authored-by: Anisha Ramnani <[email protected]>

Co-authored-by: Tahsina Islam <[email protected]>

Co-authored-by: Anisha Ramnani <[email protected]>

…ior-year-access-flow Co-authored-by: Anisha Ramnani <[email protected]>

Co-authored-by: Anisha Ramnani <[email protected]>

mrotondo

One hunch of a potential bug in the interaction between this story and the previous one that I'd like you to check out, and one request for changes to comments, but looks good other than that! LMK when you've gotten a chance to check out the potential interaction with failed verification code attempts & I'll approve.

mrotondo · 2025-01-17T23:41:34Z

app/controllers/state_file/archived_intakes/identification_number_controller.rb

+          # need to change to address controller
+        else
+          create_state_file_access_log("incorrect_ssn_challenge")
+          current_request.increment_failed_attempts


It looks like we're re-using the same mechanism for marking "failed attempts" here as on the verification code page. If the user mis-enters a verification code and then gets it right on their second try, will that count against their total allowed failed attempts? In other words, should we reset failed attempts to zero after a user succeeds verification code authorization?

oh I thought we did this in both controllers when the form is valid by line 17: current_request.reset_failed_attempts! but i could be wrong would be down to discuss on tuesday!

mrotondo · 2025-01-17T23:48:00Z

spec/controllers/state_file/archived_intake/identification_number_controller_spec.rb

+        expect(intake_request.reload.failed_attempts).to eq(0)
+
+        expect(response).to redirect_to(root_path)
+        # need to change to address path


Can you replace these comments with a TODO that reference the story ID where the work to change the path will be done?

jnf and others added 29 commits December 27, 2024 12:01

i don't know why i had to do this

30dd34b

can navigate to email address page

2d1f3f1

rename files and add link

36a8be4

delete unused controller

eb43c45

remove unused data migration

ca18535

i18n health

a8ad9db

intake archiving (models and migrations) (#5299)

1cfc369

wip

5b22894

merge in migrations

a32e759

wip

a0969e3

Fyst 1515 add prior year access link button to homepage (#5296)

f1e5246

Co-authored-by: Drew Proebstel <[email protected]>

wip

234b1e3

Merge branch 'main' into FYST-1466-prior-year-access-mvp

1b95140

email form is not using questions controller

0798ab6

update unused file

4181a66

remove unused prys

5162bf6

pages navigate

c39a237

Revert "Fyst 1515 add prior year access link button to homepage (#5296)…

be8795e

…" (#5317) This reverts commit f1e5246. Co-authored-by: Drew Proebstel <[email protected]>

Merge remote-tracking branch 'origin/FYST-1466-prior-year-access-mvp'…

e7d479c

… into FYST-1516-add-email-validation-step-to-prior-year-access-flow

delete unused views

90da001

Merge remote-tracking branch 'origin/main' into FYST-1466-prior-year-…

10b64ec

…access-mvp

some tests

e3be6ee

update schema

4bc1aaf

wip

32803b9

Merge branch 'FYST-1466-prior-year-access-mvp' into FYST-1516-add-ema…

9b26ce6

…il-validation-step-to-prior-year-access-flow

verification code is being sent

cff9432

remove pry

a9df1c4

adds missing form

8d0787e

anisharamnani commented Jan 15, 2025

View reviewed changes

tahsinaislam force-pushed the FYST-1517-add-ssn-itin-validation-step-to-prior-year-access-flow branch from 9ebf568 to b8dd33c Compare January 15, 2025 20:20

anisharamnani force-pushed the FYST-1517-add-ssn-itin-validation-step-to-prior-year-access-flow branch from b8dd33c to 66ee195 Compare January 15, 2025 20:28

tahsinaislam and others added 21 commits January 15, 2025 14:37

Merge branch 'main' into FYST-1517-add-ssn-itin-validation-step-to-pr…

0681953

…ior-year-access-flow Co-authored-by: Anisha Ramnani <[email protected]>

Fix

5a284ea

Co-authored-by: Anisha Ramnani <[email protected]>

Add form

47eaf76

Co-authored-by: Anisha Ramnani <[email protected]>

change identification number form

1102e07

Co-authored-by: Tahsina Islam <[email protected]>

Merge remote-tracking branch 'origin/main' into FYST-1517-add-ssn-iti…

182cdde

…n-validation-step-to-prior-year-access-flow Co-authored-by: Tahsina Islam <[email protected]>

Add form logic

c4cd073

Co-authored-by: Anisha Ramnani <[email protected]>

Update form

6990d0e

Co-authored-by: Anisha Ramnani <[email protected]>

Fix associations with StateFileArchivedIntake class

cab589c

Co-authored-by: Anisha Ramnani <[email protected]>

Add error strings

fa1a9b6

Co-authored-by: Anisha Ramnani <[email protected]>

Fix reference

6145d0d

Co-authored-by: Anisha Ramnani <[email protected]>

Fix form

2c55485

Co-authored-by: Anisha Ramnani <[email protected]>

Update controller lgic

e985d95

Co-authored-by: Anisha Ramnani <[email protected]>

Merge branch 'main' into FYST-1517-add-ssn-itin-validation-step-to-pr…

95ba16f

…ior-year-access-flow Co-authored-by: Anisha Ramnani <[email protected]>

fix controller

279ea97

Co-authored-by: Anisha Ramnani <[email protected]>

create id controller test

3225a04

Co-authored-by: Tahsina Islam <[email protected]>

Fix controller

3d238b6

Co-authored-by: Anisha Ramnani <[email protected]>

fix feature

174d29e

Co-authored-by: Anisha Ramnani <[email protected]>

Merge branch 'main' into FYST-1517-add-ssn-itin-validation-step-to-pr…

7616e78

…ior-year-access-flow Co-authored-by: Anisha Ramnani <[email protected]>

Add offbaording page

fee9551

Co-authored-by: Anisha Ramnani <[email protected]>

Updated verification code controller spec

0b0c9e1

Co-authored-by: Anisha Ramnani <[email protected]>

normalize i18

8f3fab9

Co-authored-by: Anisha Ramnani <[email protected]>

tahsinaislam marked this pull request as ready for review January 17, 2025 22:39

mrotondo reviewed Jan 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fyst 1517 add ssn itin validation step to prior year access flow #5326

Fyst 1517 add ssn itin validation step to prior year access flow #5326

anisharamnani commented Jan 8, 2025 •

edited by tahsinaislam

Loading

github-actions bot commented Jan 8, 2025

anisharamnani Jan 15, 2025

anisharamnani Jan 15, 2025

anisharamnani Jan 15, 2025

anisharamnani Jan 15, 2025

anisharamnani Jan 15, 2025

mrotondo left a comment

mrotondo Jan 17, 2025

tahsinaislam Jan 18, 2025

mrotondo Jan 17, 2025

		@@ -0,0 +1,12 @@
		module Navigation
		class CompletedTaxReturnNavigation < Navigation::StateFileBaseQuestionNavigation

		@@ -0,0 +1,2 @@
		<% content_for :page_title, t(".title") do %>

Fyst 1517 add ssn itin validation step to prior year access flow #5326

Are you sure you want to change the base?

Fyst 1517 add ssn itin validation step to prior year access flow #5326

Conversation

anisharamnani commented Jan 8, 2025 • edited by tahsinaislam Loading

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

What was done?

How to test?

Screenshots (for visual changes)

github-actions bot commented Jan 8, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrotondo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anisharamnani commented Jan 8, 2025 •

edited by tahsinaislam

Loading