Archived clients should not trigger external Hub notifications #6068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-6068-86f77a2abe22.herokuapp.com/ |
embarnard
commented
Sep 26, 2025
| users_to_contact.each do |user| | ||
| interaction = ClientInteraction.create!(client: client, interaction_type: interaction_type) | ||
| ClientInteractionNotificationEmailJob.set(wait: 10.minutes).perform_later(interaction, user, **email_attrs) | ||
| ClientInteractionNotificationEmailJob.set(wait: 10.minutes).perform_later(interaction, user, **email_attrs) unless client.has_archived_intake? |
Contributor
Author
There was a problem hiding this comment.
stops emails for document_upload, new_client_message and signed_8879:
embarnard
commented
Sep 26, 2025
| ) | ||
| ) | ||
| SendInternalEmailJob.perform_later(internal_email) | ||
| SendInternalEmailJob.perform_later(internal_email) unless client.has_archived_intake? |
Contributor
Author
There was a problem hiding this comment.
stops emails for tagged_in_note
embarnard
commented
Sep 26, 2025
| end | ||
|
|
||
| def send_notifications | ||
| return if @client.has_archived_intake? |
Contributor
Author
There was a problem hiding this comment.
stops emails for assigned to client
embarnard
deleted the
GYR1-811-archived-clients-should-not-trigger-external-hub-notifications
branch
tahsinaislam
pushed a commit
that referenced
this pull request
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
messages
document upload and 8879
I don't think archived clients can login to the portal
client assignment
as a hub user assign an archived client to another hub user that has their notification on
Tagged in note
as a hub user tag another user in the notes of an archived client