Skip to content

Conversation

@anisharamnani
Copy link
Contributor

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • No - merge after code review approval

Reminder: merge main into this branch and get green tests before merging to main

What was done?

currently the main branch is failing due to this flakey test, this is will hopefully fix things by waiting for each page to change.

How to test?

  • Describe the testing approach taken to verify the changes, including:
    it’s a test itself!

@anisharamnani
Copy link
Contributor Author

⭐ paired with kevin but didn’t add him to the git duet commit. i will be adding him to the merge commit though.

@github-actions
Copy link

Heroku app: https://gyr-review-app-6069-01ab4d186ad6.herokuapp.com/
View logs: heroku logs --app gyr-review-app-6069 (optionally add --tail)

Copy link
Contributor

@powersurge360 powersurge360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anisharamnani anisharamnani merged commit 305b583 into main Sep 25, 2025
8 checks passed
@anisharamnani anisharamnani deleted the FYST-2286-fix-flaky-test-spec-features-hub-clients-searching-sorting-and-filtering-spec-rb-378 branch September 25, 2025 20:37
Copy link
Contributor

@DrewProebstel DrewProebstel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good use of page_change_block

tahsinaislam pushed a commit that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants