Today and Tomorrow notification message query cleanup #6072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… present, move dupe check and disqualified df check to batch loop and change test for send_deadline_reminder_today_service
|
Heroku app: https://gyr-review-app-6072-657b5e3affb8.herokuapp.com/ |
embarnard
changed the title
embarnard
commented
Sep 26, 2025
app/models/state_file_base_intake.rb
Outdated
| def self.selected_intakes_for_deadline_reminder_notifications | ||
| self.left_joins(:efile_submissions) | ||
| .where(efile_submissions: { id: nil }) | ||
| self.missing(:efile_submissions) |
Contributor
Author
There was a problem hiding this comment.
anisharamnani
approved these changes
Sep 26, 2025
mrotondo
approved these changes
Sep 26, 2025
Contributor
mrotondo
left a comment
mrotondo
left a comment
There was a problem hiding this comment.
looks good, nice change!
tahsinaislam
pushed a commit
that referenced
this pull request
Oct 15, 2025
* Prevent checking disqualifying_df_data_reason unless direct_file_data present, move dupe and disqualified df check to batched loop, add indexes for verified contact info and created at on state file intakes and change test for send_deadline_reminder_today_service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?