Skip to content

Change selected intakes for oct 21 and 22 to only send to intakes with df data imported #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
embarnard merged 2 commits into from
Sep 30, 2025
Merged

Change selected intakes for oct 21 and 22 to only send to intakes with df data imported #6074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0e4cd3
Change selected intakes for oct 21 and 22 to only send to intakes wit…
embarnard Sep 29, 2025
c54dce3
Changes
embarnard Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions app/models/state_file_base_intake.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,12 @@ def self.state_code
delegate :state_code, to: :class

def self.selected_intakes_for_deadline_reminder_soon_notifications
self.where.missing(:efile_submissions)
.has_verified_contact_info
.where(created_at: Time.current.beginning_of_year..Time.current.end_of_year)
intakes = self.where.missing(:efile_submissions)
.where.not(df_data_imported_at: nil)
.has_verified_contact_info
.where(created_at: Time.current.beginning_of_year..Time.current.end_of_year)

intakes.select { |i| !i.disqualifying_df_data_reason.present? && !i.other_intake_with_same_ssn_has_submission? }
end

def self.selected_intakes_for_deadline_reminder_notifications
Expand Down
3 changes: 0 additions & 3 deletions app/services/state_file/send_deadline_reminder_today_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ def self.run
intakes_to_notify.each_slice(BATCH_SIZE) do |batch|
batch.each do |intake|
begin
if (intake.raw_direct_file_data.present? && intake.disqualifying_df_data_reason.present?) || intake.other_intake_with_same_ssn_has_submission?
next
end
StateFile::MessagingService.new(
message: StateFile::AutomatedMessage::DeadlineReminderToday,
intake: intake
Expand Down
29 changes: 17 additions & 12 deletions spec/models/state_file_base_intake_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,14 +594,16 @@
create :state_file_az_intake,
email_address: '[email protected]',
email_address_verified_at: 5.minutes.ago,
email_notification_opt_in: 1
email_notification_opt_in: 1,
df_data_imported_at: 2.minutes.ago
}
let!(:az_intake_from_last_year) {
create :state_file_az_intake,
email_address: '[email protected]',
email_address_verified_at: 5.minutes.ago,
email_notification_opt_in: 1,
created_at: 1.year.ago
created_at: 1.year.ago,
df_data_imported_at: 2.minutes.ago
}
let!(:az_intake_with_email_notifications_without_df_import) {
create :state_file_az_intake,
Expand All @@ -615,37 +617,42 @@
email_address: '[email protected]',
phone_number: "+15551115511",
sms_notification_opt_in: 1,
phone_number_verified_at: 5.minutes.ago
phone_number_verified_at: 5.minutes.ago,
df_data_imported_at: 2.minutes.ago
}
let!(:az_intake_with_unverified_text_notifications_and_df_import) {
create :state_file_az_intake,
email_address: '[email protected]',
phone_number: "+15551115511",
sms_notification_opt_in: "yes",
email_address_verified_at: 5.minutes.ago,
email_notification_opt_in: "no"
email_notification_opt_in: "no",
df_data_imported_at: 2.minutes.ago
}
let!(:az_intake_submitted) {
create :state_file_az_intake,
email_address: '[email protected]',
email_address_verified_at: 5.minutes.ago,
email_notification_opt_in: 1
email_notification_opt_in: 1,
df_data_imported_at: 2.minutes.ago
}
let!(:efile_submission) { create :efile_submission, :for_state, data_source: az_intake_submitted }
let!(:az_intake_has_disqualifying_df_data) {
create :state_file_az_intake,
filing_status: :married_filing_separately,
email_address: "[email protected]",
email_address_verified_at: 1.hour.ago,
email_notification_opt_in: 1
email_notification_opt_in: 1,
df_data_imported_at: 2.minutes.ago
}
let!(:az_intake_submitted_ssn_duplicate) {
create :state_file_az_intake,
email_address: "[email protected]",
email_address_verified_at: 1.hour.ago,
email_notification_opt_in: 1,
phone_number: nil,
hashed_ssn: "111443333"
hashed_ssn: "111443333",
df_data_imported_at: 2.minutes.ago
}
let!(:efile_submission_for_duplicate) { create :efile_submission, :for_state, data_source: az_intake_submitted_ssn_duplicate }
let!(:az_intake_submitted_ssn_duplicate_1) {
Expand All @@ -654,23 +661,21 @@
email_address_verified_at: 1.hour.ago,
email_notification_opt_in: 1,
phone_number: nil,
hashed_ssn: "111443333"
hashed_ssn: "111443333",
df_data_imported_at: 2.minutes.ago
}

before do
allow(Flipper).to receive(:enabled?).and_call_original
allow(Flipper).to receive(:enabled?).with(:prevent_duplicate_ssn_messaging).and_return(true)
end

it "returns intakes with verified contact info, with or without df data, and without efile submissions" do
it "returns intakes WITH verified contact info & df data import and WITHOUT efile submissions, duplicates (where one has an efile submission) & disqualifying df data reasons" do
results = StateFileAzIntake.selected_intakes_for_deadline_reminder_soon_notifications
intakes_to_message = [
az_intake_with_email_notifications_and_df_import,
az_intake_with_text_notifications_and_df_import,
az_intake_with_email_notifications_without_df_import,
az_intake_with_unverified_text_notifications_and_df_import,
az_intake_has_disqualifying_df_data,
az_intake_submitted_ssn_duplicate_1
]
expect(results).to match_array(intakes_to_message)
end
Expand Down
152 changes: 22 additions & 130 deletions spec/tasks/send_deadline_reminder_today_service_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,146 +7,38 @@
allow(Flipper).to receive(:enabled?).with(:prevent_duplicate_ssn_messaging).and_return(true)
messaging_service = spy('StateFile::MessagingService')
allow(StateFile::MessagingService).to receive(:new).and_return(messaging_service)
allow(StateFileAzIntake).to receive(:selected_intakes_for_deadline_reminder_soon_notifications).and_return([az_intake_1, md_intake, nc_intake, id_intake, nj_intake])
end

around do |example|
# freezing the time to any time in 2025, since this task will only run in 2025
Timecop.freeze(DateTime.parse("2-12-2025")) do
example.run
end
end

context "for AZ intakes" do
let!(:az_intake_with_email_notifications_and_df_import) {
create :state_file_az_intake,
email_address: '[email protected]',
email_address_verified_at: 5.minutes.ago,
email_notification_opt_in: 1
}
let!(:az_intake_with_email_notifications_and_df_import_from_last_year) {
create :state_file_az_intake,
email_address: '[email protected]',
email_address_verified_at: 5.minutes.ago,
email_notification_opt_in: 1,
created_at: (1.year.ago)
}
let!(:az_intake_with_email_notifications_without_df_import) {
create :state_file_az_intake,
raw_direct_file_data: nil,
email_address: '[email protected]',
email_address_verified_at: 5.minutes.ago,
email_notification_opt_in: 1
}
let!(:az_intake_with_sms_and_df_import) {
create :state_file_az_intake,
email_address: '[email protected]',
phone_number: "+15551115511",
sms_notification_opt_in: 1,
phone_number_verified_at: 5.minutes.ago
}
let!(:az_intake_with_unverified_sms_verified_email) {
create :state_file_az_intake,
phone_number: "+15551115511",
sms_notification_opt_in: "yes",
email_address: '[email protected]',
email_address_verified_at: 5.minutes.ago,
email_notification_opt_in: "no"
}
let!(:az_intake_submitted) {
create :state_file_az_intake,
email_address: '[email protected]',
email_address_verified_at: 5.minutes.ago,
email_notification_opt_in: 1
}
let!(:efile_submission) { create :efile_submission, :for_state, data_source: az_intake_submitted }
let!(:az_intake_has_disqualifying_df_data) {
create :state_file_az_intake,
filing_status: :married_filing_separately,
email_address: "[email protected]",
email_address_verified_at: 1.hour.ago,
email_notification_opt_in: 1
}
let!(:az_intake_with_no_raw_direct_file_data) {
create :state_file_az_intake,
raw_direct_file_data: nil,
raw_direct_file_intake_data: nil,
email_address: '[email protected]',
email_address_verified_at: 5.minutes.ago,
email_notification_opt_in: 1
}
let!(:az_intake_submitted_ssn_dupe_with_submission) {
create :state_file_az_intake,
email_address: "[email protected]",
email_address_verified_at: 1.hour.ago,
email_notification_opt_in: 1,
phone_number: nil,
hashed_ssn: "111443333"
}
let!(:efile_submission_for_duplicate) {
create :efile_submission,
:for_state,
data_source: az_intake_submitted_ssn_dupe_with_submission
}
let!(:az_intake_submitted_ssn_match_for_dupe) {
create :state_file_az_intake,
email_address: "[email protected]",
email_address_verified_at: 1.hour.ago,
email_notification_opt_in: 1,
phone_number: nil,
hashed_ssn: "111443333"
}
let(:az_intake_1) { create :state_file_az_intake }
let!(:az_intake_2) { create :state_file_az_intake }
let(:md_intake) { create :state_file_md_intake }
let(:nc_intake) { create :state_file_nc_intake }
let(:id_intake) { create :state_file_id_intake }
let(:nj_intake) { create :state_file_nj_intake }
let!(:ny_intake) { create :state_file_ny_intake }

it 'sends to intakes with verified contact info, with or without df data, and without efile submissions or duplicate (same hashed_ssn) intakes with efile submission' do
message = StateFile::AutomatedMessage::DeadlineReminderToday
service = StateFile::MessagingService

it 'sends to intakes with verified contact info, with or without df data, and without efile submissions or duplicate (same hashed_ssn) intakes with efile submission' do
Rake::Task['state_file:send_deadline_reminder_today'].execute
expect(StateFile::MessagingService).to have_received(:new).exactly(5).times
expect(StateFile::MessagingService).to have_received(:new).with(
message: StateFile::AutomatedMessage::DeadlineReminderToday,
intake: az_intake_with_email_notifications_and_df_import
)
expect(StateFile::MessagingService).to have_received(:new).with(
message: StateFile::AutomatedMessage::DeadlineReminderToday,
intake: az_intake_with_email_notifications_without_df_import
)
expect(StateFile::MessagingService).to have_received(:new).with(
message: StateFile::AutomatedMessage::DeadlineReminderToday,
intake: az_intake_with_sms_and_df_import
)
expect(StateFile::MessagingService).to have_received(:new).with(
message: StateFile::AutomatedMessage::DeadlineReminderToday,
intake: az_intake_with_unverified_sms_verified_email
)
expect(StateFile::MessagingService).to have_received(:new).with(
message: StateFile::AutomatedMessage::DeadlineReminderToday,
intake: az_intake_with_no_raw_direct_file_data
)
end
end
Rake::Task['state_file:send_deadline_reminder_today'].execute
expect(service).to have_received(:new).exactly(5).times

context "for NJ intakes" do
let!(:nj_intake_with_email_notifications_and_df_import) {
create :state_file_nj_intake,
email_address: '[email protected]',
email_address_verified_at: 5.minutes.ago,
email_notification_opt_in: 1
}
let!(:nj_intake_with_email_notifications_without_df_import) {
create :state_file_nj_intake,
raw_direct_file_data: nil,
email_address: '[email protected]',
email_address_verified_at: 5.minutes.ago,
email_notification_opt_in: 1
}
it 'sends to intakes with verified contact info, with or without df data, and without efile submissions or duplicate (same hashed_ssn) intakes with efile submission' do
Rake::Task['state_file:send_deadline_reminder_today'].execute
expect(StateFile::MessagingService).to have_received(:new).exactly(2).times
expect(StateFile::MessagingService).to have_received(:new).with(
message: StateFile::AutomatedMessage::DeadlineReminderToday,
intake: nj_intake_with_email_notifications_and_df_import
)
expect(StateFile::MessagingService).to have_received(:new).with(
message: StateFile::AutomatedMessage::DeadlineReminderToday,
intake: nj_intake_with_email_notifications_without_df_import
)
end
expect(service).to have_received(:new).with(message: message, intake: az_intake_1)
expect(service).to have_received(:new).with(message: message, intake: md_intake)
expect(service).to have_received(:new).with(message: message, intake: nc_intake)
expect(service).to have_received(:new).with(message: message, intake: id_intake)
expect(service).to have_received(:new).with(message: message, intake: nj_intake)

expect(service).not_to have_received(:new).with(message: message, intake: az_intake_2)
expect(service).not_to have_received(:new).with(message: message, intake: ny_intake)
end
end
Loading