FYST-2261-remove-all-fyst-state-file-notification-jobs-from-the-crontab #6098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-6098-08f1dd20bcda.herokuapp.com/ |
DrewProebstel
changed the title
mrotondo
reviewed
Oct 29, 2025
crontab
Outdated
Comment on lines
15
to
17
| 0 18 16 10 * bundle exec rake state_file:send_october_transfer_reminder | ||
| 0 18 21 10 * bundle exec rake state_file:send_deadline_reminder_tomorrow | ||
| 0 18 22 10 * bundle exec rake state_file:send_deadline_reminder_today |
Contributor
There was a problem hiding this comment.
The dates for these three have passed - should they be commented out/removed as well?
Contributor
Author
There was a problem hiding this comment.
Good idea. It couldn't hurt.
crontab
Outdated
| @@ -7,11 +7,11 @@ | |||
| 15 20 * * * bundle exec rake not_ready_reminders:remind | |||
| */5 * * * * bundle exec rake worker_heartbeat:perform | |||
| */10 * * * 1-6 bundle exec rake efile:poll_and_get_acknowledgments | |||
Contributor
There was a problem hiding this comment.
Do we have another ticket to comment out/remove this after we stop filing on 10/31 (state_file_end_of_in_progress_intakes)?
mrotondo
approved these changes
Oct 30, 2025
Contributor
mrotondo
left a comment
mrotondo
left a comment
There was a problem hiding this comment.
looks good! let's make sure this doesn't get merged & pushed until after 10/31.
DrewProebstel
deleted the
FYST-2261-remove-all-fyst-state-file-notification-jobs-from-the-crontab
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is PM acceptance required? (delete one)!
What was done?