Skip to content

Conversation

@embarnard
Copy link
Contributor

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • add documents page in the hub doesn’t require that you select a tax return, so if you submit that field blank there will be no tax year on the confirm page and it will error out
  • prevent page from erroring if document has no tax return

How to test?

Screenshots (for visual changes)

  • Before
Screenshot 2026-01-26 at 2 46 23 PM
  • After
Screenshot 2026-01-26 at 2 46 36 PM

@github-actions
Copy link

Heroku app: https://gyr-review-app-6167-dec27892ec22.herokuapp.com/
View logs: heroku logs --app gyr-review-app-6167 (optionally add --tail)

Copy link
Contributor

@spompea-cfa spompea-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@embarnard embarnard merged commit 068c8ab into main Jan 28, 2026
8 checks passed
@embarnard embarnard deleted the GYR1-910-hub-doc-year-error branch January 28, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants