GYR1-905 Remove ICE banner and update ITIN guidance #6168
Conversation
|
Heroku app: https://gyr-review-app-6168-e4c6a8143b61.herokuapp.com/ |
embarnard
left a comment
embarnard
left a comment
There was a problem hiding this comment.
There seems to be some unrelated migrations wrapped up in this? Also should we just remove it instead of commenting it out
| # | ||
| # Indexes | ||
| # | ||
| # index_state_file_az_intakes_email_verified (id) WHERE ((email_address IS NOT NULL) AND (email_address_verified_at IS NOT NULL)) |
There was a problem hiding this comment.
Is there a reason why you're removing these or is this a mistake?
app/models/user.rb
Outdated
| # current_sign_in_ip :string | ||
| # document_upload_notification :integer default("yes"), not null | ||
| # email :citext not null | ||
| # email_notification :integer default(0), not null |
There was a problem hiding this comment.
also this, I suspect your db is out of sync
There was a problem hiding this comment.
I ran db:reset and this is what changed. I also tried db:migrate:reset, but hit an error on the first migration file that the expected table didn't exist. This is the first time I've run migrations since they were collapsed, is there another step I need to do? Are you able to run a db reset (with or without migrate)?
mpidcock
force-pushed
the
GYR1-905-itin-filers-update
branch
from
4f43038 to
5188c10
Compare
mpidcock
force-pushed
the
GYR1-905-itin-filers-update
branch
from
5188c10 to
639af2d
Compare
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
Screenshots (for visual changes)