GYR1-977-allow-returning-file-myself-users-to-navigate-to-tax-slayer-without-error

[DrewProebstel]

Link to pivotal/JIRA issue

• https://codeforamerica.atlassian.net/browse/GYR1-977

Is PM acceptance required? (delete one)

• Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

• Remove the unique constraint on campaign email and allows at most 2 to be created

How to test?

• make sure "send_diy_survey" flipper tag is on

[github-actions]

Heroku app: https://gyr-review-app-6239-0a43e1abc58e.herokuapp.com/
View logs: heroku logs --app gyr-review-app-6239 (optionally add --tail)

[embarnard]

@DrewProebstel i guess I'm worried about the case where we are batching emails and the batches that are creating the emails overlap. So you have the some of the same contacts in both batches. Before when we had this uniqueness constraint it would catch these and never create duplicate emails by message name for the same client. Now it could theoretically? I wonder if we could add something similar to what we have in the automated messages controller like self.send_only_once? so in CampaignMessage::DiyFollowupSurvey send_only_once? would return true but in the other CampaignMessages its false and we check for this before actually sending the message in Campaign::SendCampaignEmailJob.perform?

[embarnard]

check for exisitng message and see if scheduled_send_at has already passed before trying to send one

[DrewProebstel]

@DrewProebstel i guess I'm worried about the case where we are batching emails and the batches that are creating the emails overlap. So you have the some of the same contacts in both batches. Before when we had this uniqueness constraint it would catch these and never create duplicate emails by message name for the same client. Now it could theoretically? I wonder if we could add something similar to what we have in the automated messages controller like self.send_only_once? so in CampaignMessage::DiyFollowupSurvey send_only_once? would return true but in the other CampaignMessages its false and we check for this before actually sending the message in Campaign::SendCampaignEmailJob.perform?

https://github.com/codeforamerica/vita-min/pull/6239/changes#diff-ec4b175698c9c3507597e2ae87048fd7522facfcfcebd9cce4d897ed43128e53R40

I think this like would keep duplicate emails from being batched at the same time rather than checking them in the job since if they are in different batches we may not pick up on the fact that they are duplicated. I added the uniqueness restraint back to the start_of_season_outreach messages. And the above lines should prevent having two 'diy_surveys' batched.

[embarnard]

maybe down the line we would also check for a successful delivery but we don't have to worry about that now probably