Conversation
| @county_data = LocationData::Counties.get(@screener.state, @screener.county) | ||
| @state = @screener.state | ||
| @county = @screener.county | ||
| attachments.inline["gbh_email_header.png"] = File.binread(Rails.root.join("app/assets/images/gbh_email_header.png")) |
Collaborator
There was a problem hiding this comment.
i’m not totally sure why these need to be instance variables since they’re accessible by the @screener
Contributor
Author
There was a problem hiding this comment.
I removed them, and just created the state and county in the two erb files to make things easier to read!
anisharamnani
approved these changes
Apr 3, 2026
cram-cfa
commented
Apr 3, 2026
| <% state = @screener.state %> | ||
| <% county = @screener.county %> | ||
| <% website = LocationData::Counties.website_for(state, county) %> | ||
| <% email = LocationData::Counties.email_for(state, county) %> |
Contributor
Author
There was a problem hiding this comment.
These are just so make it easier to read, since the values are reused in a couple places within the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.