Conversation
jenny-heath
reviewed
Apr 6, 2026
cram-cfa
commented
Apr 7, 2026
|
|
||
| config.active_record.encryption.primary_key = ENV.fetch("ACTIVE_RECORD_ENCRYPTION_PRIMARY_KEY") | ||
| config.active_record.encryption.deterministic_key = ENV.fetch("ACTIVE_RECORD_ENCRYPTION_DETERMINISTIC_KEY") | ||
| config.active_record.encryption.key_derivation_salt = ENV.fetch("ACTIVE_RECORD_DERIVATION_SALT_KEY") |
Contributor
Author
There was a problem hiding this comment.
Slightly annoying that this has to be in both staging.rb and production.rb but if it's in application.rb, this will barf locally for devs because application.rb will spit out the exception before development.rb is run
cram-cfa
commented
Apr 7, 2026
| <% unless has_email %> | ||
| <div> | ||
| <%= link_to(generate_pdf_path, class: "button button--primary spacing-below-0") do %> | ||
| <%= link_to(generate_pdf_path, class: "button button--primary spacing-below-0", target: "_blank") do %> |
Contributor
Author
There was a problem hiding this comment.
I missed the target: "_blank" here but we should have this so the PDF opens in a new tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.