[WRSAT-177] create reminders email screen #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
anisharamnani
commented
Jan 7, 2026
anisharamnani
commented
jenny-heath
reviewed
Jan 8, 2026
app/controllers/email_controller.rb
Outdated
Comment on lines
5
to
12
|
|
||
| def progress_bar_step | ||
| 3 | ||
| end | ||
|
|
||
| def section_name | ||
| I18n.t("general.basic_information") | ||
| end |
Collaborator
There was a problem hiding this comment.
Suggested change
| def progress_bar_step | |
| 3 | |
| end | |
| def section_name | |
| I18n.t("general.basic_information") | |
| end |
Collaborator
There was a problem hiding this comment.
this stuff is already in BasicInfoConcern! so you just have to include that
jenny-heath
reviewed
Jan 8, 2026
jenny-heath
reviewed
Jan 8, 2026
jenny-heath
reviewed
Jan 8, 2026
app/models/screener.rb
Outdated
| end | ||
|
|
||
| with_context :email do | ||
| validates :email, 'valid_email_2/email': true, confirmation: true |
Collaborator
There was a problem hiding this comment.
sorry to be a square but you should add a test to screener_spec.rb for this
Collaborator
Author
There was a problem hiding this comment.
you aren’t being a square! i knew i was going to be missing things, because while i’ve reviewed things this is one of the first i’ve done in some time.
Collaborator
|
looks like you need to lint! |
jenny-heath
approved these changes
Jan 8, 2026
…nders-email-screen
anisharamnani
temporarily deployed
to
wrsat-wrsat-177-create--78vtr4
anisharamnani
temporarily deployed
to
wrsat-wrsat-177-create--78vtr4
anisharamnani
temporarily deployed
to
wrsat-wrsat-177-create--mvz1ie
jenny-heath
reviewed
Jan 14, 2026
Comment on lines
65
to
69
|
|
||
| def strip_email | ||
| self.email = email.strip if email.present? | ||
| self.email_confirmation = email_confirmation.strip if email_confirmation.present? | ||
| end |
Collaborator
There was a problem hiding this comment.
so above i'm using normalizes for phone number. it applies more broadly than before_validation and i'm not completely sure what my opinion is on one vs the other. maybe we chat about it!
anisharamnani
temporarily deployed
to
wrsat-wrsat-177-create--mvz1ie
anisharamnani
temporarily deployed
to
wrsat-wrsat-177-create--q3sxee
anisharamnani
temporarily deployed
to
wrsat-wrsat-177-create--q3sxee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.