Fix phone validator #70
Conversation
| select "1940", from: "Year" | ||
| fill_in I18n.t("views.personal_information.edit.phone_number_label"), with: "555-222-3333" | ||
| fill_in I18n.t("views.personal_information.edit.phone_number_label"), with: "415-816-1286" | ||
| click_on I18n.t("general.continue") |
There was a problem hiding this comment.
why did you change the number here? why did the first one work?
There was a problem hiding this comment.
unfortunately i couldn't actually find anything in the phonelib documentation about it, so i assumed that this worked because phone numbers starting with 555 are fake and therefore treated differently? or at least not treated the same as US numbers. the being-fake part is why i tend to use them for tests but then as you found, it wasn't accepting real phone numbers because the validation i was using expected there to be a country code. the number i've used here is cfa's office number which i feel fine about using in a test. lmk if you have concerns about this though!
There was a problem hiding this comment.
ah, that makes sense. thank you for explaining this to me!
jenny-heath
deleted the
WRSAT-245-bug-phone-number-field-on-personal-info-screen-doesnt-accept-valid-phone-numbers
branch
phone: truewill return false if the phone number doesn't have a country code)