-
Notifications
You must be signed in to change notification settings - Fork 0
WRSAT-187 create training program screen #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| params = { | ||
| is_in_work_training: "yes", | ||
| work_training_hours: "5", | ||
| work_training_name: "How to do job" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that’s a good job
| expect(page).to have_selector("h1", text: I18n.t("views.work_training.edit.title")) | ||
| choose I18n.t("general.affirmative") | ||
| fill_in I18n.t("views.work_training.edit.work_training_hours_label"), with: "20" | ||
| fill_in I18n.t("views.work_training.edit.work_training_name_label"), with: "The Great British Work Off" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok better job
anisharamnani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ creating an additional bug ticket makes sense, thanks jenny for this work!
|
closing to fix heroku app |
|
trying again |
there is one known issue with this: when you go back to the page (either with "go back" or browser back), the reveal breaks.
^related: the reveals all seem to be broken currently, but i was able to fix that in this PR by calling
revealer.init();on theturbo:loadhook inapplication.js. i don't understand why the reveals were broken in the first place. also, callinghoneycrispInit();in theturbo:loadhook is supposed to fix the js functionality on back AND should includerevealer.init();, but it does not seem to?i'd like to put this in a separate bug ticket because i don't want to get stuck on this one for too long.