Skip to content

Conversation

@jenny-heath
Copy link
Collaborator

@jenny-heath jenny-heath commented Jan 20, 2026

there is one known issue with this: when you go back to the page (either with "go back" or browser back), the reveal breaks.

^related: the reveals all seem to be broken currently, but i was able to fix that in this PR by calling revealer.init(); on the turbo:load hook in application.js. i don't understand why the reveals were broken in the first place. also, calling honeycrispInit(); in the turbo:load hook is supposed to fix the js functionality on back AND should include revealer.init();, but it does not seem to?

i'd like to put this in a separate bug ticket because i don't want to get stuck on this one for too long.

image Screenshot 2026-01-21 at 3 24 16 PM

@jenny-heath jenny-heath temporarily deployed to wrsat-wrsat-187-create--enbnqw January 20, 2026 17:59 Inactive
@jenny-heath jenny-heath temporarily deployed to wrsat-wrsat-187-create--enbnqw January 20, 2026 23:21 Inactive
@jenny-heath jenny-heath temporarily deployed to wrsat-wrsat-187-create--enbnqw January 21, 2026 23:18 Inactive
@jenny-heath jenny-heath temporarily deployed to wrsat-wrsat-187-create--enbnqw January 21, 2026 23:23 Inactive
@jenny-heath jenny-heath temporarily deployed to wrsat-wrsat-187-create--enbnqw January 21, 2026 23:25 Inactive
@jenny-heath jenny-heath marked this pull request as ready for review January 21, 2026 23:34
params = {
is_in_work_training: "yes",
work_training_hours: "5",
work_training_name: "How to do job"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that’s a good job

expect(page).to have_selector("h1", text: I18n.t("views.work_training.edit.title"))
choose I18n.t("general.affirmative")
fill_in I18n.t("views.work_training.edit.work_training_hours_label"), with: "20"
fill_in I18n.t("views.work_training.edit.work_training_name_label"), with: "The Great British Work Off"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok better job

Copy link
Collaborator

@anisharamnani anisharamnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ creating an additional bug ticket makes sense, thanks jenny for this work!

@jenny-heath
Copy link
Collaborator Author

closing to fix heroku app

@jenny-heath jenny-heath reopened this Jan 27, 2026
@jenny-heath jenny-heath temporarily deployed to wrsat-wrsat-187-create--e1sshi January 27, 2026 23:05 Inactive
@jenny-heath jenny-heath temporarily deployed to wrsat-wrsat-187-create--e1sshi January 27, 2026 23:07 Inactive
@jenny-heath
Copy link
Collaborator Author

trying again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants