Updating setup and readme to be more robust #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenny-heath
reviewed
Jan 28, 2026
Comment on lines
+8
to
+9
| def system!(cmd) | ||
| puts "==> Running: #{cmd}" |
Collaborator
There was a problem hiding this comment.
hm does the lack of splat here make a difference?
jenny-heath
reviewed
Jan 28, 2026
| puts "\n== rbenv not found. Installing via Homebrew ==" | ||
| system!("brew install rbenv") | ||
| else | ||
| puts "rbenv already installed" |
Collaborator
There was a problem hiding this comment.
any reason this puts already installed but the docker and homebrew steps don't?
jenny-heath
reviewed
Jan 28, 2026
Comment on lines
+44
to
+45
| ENV.key?("RBENV_ROOT") || | ||
| ENV["PATH"].split(":").any? { |p| p.include?(".rbenv/shims") } |
Collaborator
There was a problem hiding this comment.
i'll be honest i don't understand this
jenny-heath
reviewed
Jan 28, 2026
| # Auto-activate mise for this process | ||
| unless ENV["MISE_SHELL"] | ||
| puts "Activating mise..." | ||
| activate = `mise activate zsh`.strip |
Collaborator
There was a problem hiding this comment.
this also i am confused by
jenny-heath
reviewed
Jan 28, 2026
Collaborator
jenny-heath
left a comment
jenny-heath
left a comment
There was a problem hiding this comment.
i got a little lost trying to understand some of the additions to the setup script. maybe we can all review it together in the next day or two!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to install a few things, set a few things in my path, change versions of a few things, etc to get the project working the first time. This is my best guess on what a clean install/setup script could look like to confirm things are installed with valid versions; Running it subsequently doesn't throw any errors for me, so at worst the next engineer has to work with me to iterate more on this!