Skip to content

Early polling marker changes from red to green on hover#69

Open
lucyq wants to merge 8 commits into
codeforboston:masterfrom
lucyq:map-sidebar-interaction
Open

Early polling marker changes from red to green on hover#69
lucyq wants to merge 8 commits into
codeforboston:masterfrom
lucyq:map-sidebar-interaction

Conversation

@lucyq

@lucyq lucyq commented Oct 25, 2016

Copy link
Copy Markdown
Member

#62

@lucyq lucyq changed the title Marker changes color on hover Early polling marker changes from red to green on hover Oct 25, 2016
@lucyq

lucyq commented Oct 26, 2016

Copy link
Copy Markdown
Member Author

-removed extraneous bootstrap modal package
-expands div on marker click if div is collapsed

Comment thread app/scripts/early_voting_mgr.js Outdated
var collapsedToggle = Boolean(document.getElementById('#collapse-toggle'+i).getAttribute("aria-expanded"));

if (collapsedToggle) {
$('#collapse'+i).collapse('show');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this make its way into multiple pull requests :P we might not want to do this, based off some of the design stuff that @WheresHJ was showing, maybe we can talk about this on tuesday?

@lucyq

lucyq commented Oct 28, 2016

Copy link
Copy Markdown
Member Author

my bad! should've put that on a separate branch & PR. i'll take it out when i get home today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants