Skip to content

Conversation

@HuanFengYeh
Copy link
Collaborator

Summary

This PR adds a user privacy check to the TestimonyHit component to hide the FollowUserButton for private users.

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

Screenshot 2025-05-14 at 8 36 17 AM

Known issues

The hit.public field is assumed to be available in the search index.

Steps to test/reproduce

  1. Go to the home page
  2. Logged in as a user who can follow others.
  3. Go to the browse testimony page
  4. Confirm that the Following Button is displayed for that private user.

@vercel
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 0:45am
maple-prod 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 14, 2025 0:45am

Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mephistic Mephistic merged commit d6fb1d5 into codeforboston:main May 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants