Update IBMiContent.ts to use validQsysName#2731
Merged
sebjulliand merged 1 commit intoJun 17, 2025
Merged
Conversation
Use validQsysName rather than individual checks
Nathaniel-King-Navarrete
temporarily deployed
to
testing_environment
June 13, 2025 02:38 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
sebjulliand
approved these changes
Jun 17, 2025
sebjulliand
left a comment
sebjulliand
left a comment
Member
There was a problem hiding this comment.
Looks good to me; good idea there!
Nathaniel-King-Navarrete
deleted the
#2366-use-validQsysName-for-validation
branch
June 20, 2025 04:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use validQsysName rather than individual checks. #2366
Changes
Removed individual checks within
validateLibraryListmethod and changed it toIBMI.validQsysNamemethod.How to test this PR
I tested this change by using the
Add to Library Listcommand. I tested adding a library name of '!@#$%'.I wasn't able to test the length > 10 case, because there is a check in
code-for-ibmi.addToLibraryListfor that case, before the call tovalidateLibraryList.I noticed that there was some test suites that tested
validateLibraryList, but I wasn't sure how to run them. Is there a way for me to call these test suites? Thanks.Checklist
console.logs I added