Fix Enter key handling in Custom UI and Editors forms#3090
Merged
sebjulliand merged 2 commits intomasterfrom Mar 11, 2026
Merged
Fix Enter key handling in Custom UI and Editors forms#3090sebjulliand merged 2 commits intomasterfrom
sebjulliand merged 2 commits intomasterfrom
Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Contributor
|
👋 A new build is available for this PR based on 17ed6df. |
chrjorgensen
requested changes
Mar 10, 2026
Collaborator
chrjorgensen
left a comment
There was a problem hiding this comment.
@sebjulliand Who uses Enter anyway...? 😂
Your fix is working as expected.
Please trim your trailing whitespace, though - and then I will approve. 😃
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Member
Author
|
Thanks for reviewing @chrjorgensen ! You can have a last look. |
Collaborator
|
@sebjulliand Great - approved by me. Merge when appropriate. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes a small regression introduced by #3083 .
Pressing Enter in a text field in a custom Webview or Editor would make the UI go blank without submitting the form.
Pressing Enter will now:
The
headinginput type has been added to the non-input type of fields. This was causing a silent crash when saving an editor.How to test this PR
Checklist