Skip to content

Fix Enter key handling in Custom UI and Editors forms#3090

Merged
sebjulliand merged 2 commits intomasterfrom
fixEnterForms
Mar 11, 2026
Merged

Fix Enter key handling in Custom UI and Editors forms#3090
sebjulliand merged 2 commits intomasterfrom
fixEnterForms

Conversation

@sebjulliand
Copy link
Member

Changes

This PR fixes a small regression introduced by #3083 .

Pressing Enter in a text field in a custom Webview or Editor would make the UI go blank without submitting the form.

Pressing Enter will now:

  • submitt the form when working with a Custom Webview (login settings, connection settings, ...)
  • do nothing when working with a Custom Editor (action, profile...)

The heading input type has been added to the non-input type of fields. This was causing a silent crash when saving an editor.

How to test this PR

  1. Open any custom webview
  2. Pressing Enter in a text field must submit the form and close the webview
  3. Open an editor (action, profile, ...)
  4. Pressing Enter in a text field must do nothing

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand added this to the 3.0.0 milestone Feb 25, 2026
@sebjulliand sebjulliand requested a review from a team February 25, 2026 17:16
@sebjulliand sebjulliand self-assigned this Feb 25, 2026
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Feb 25, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

👋 A new build is available for this PR based on 17ed6df.

Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand Who uses Enter anyway...? 😂

Your fix is working as expected.

Please trim your trailing whitespace, though - and then I will approve. 😃

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand
Copy link
Member Author

Thanks for reviewing @chrjorgensen ! You can have a last look.

@chrjorgensen
Copy link
Collaborator

@sebjulliand Great - approved by me. Merge when appropriate. 👍

@sebjulliand sebjulliand merged commit ce86dc2 into master Mar 11, 2026
4 checks passed
@sebjulliand sebjulliand deleted the fixEnterForms branch March 11, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A confirmed issue when something isn't working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants