Added missing postDownload field in action editor#3110
Open
sebjulliand wants to merge 4 commits intomasterfrom
Open
Added missing postDownload field in action editor#3110sebjulliand wants to merge 4 commits intomasterfrom
postDownload field in action editor#3110sebjulliand wants to merge 4 commits intomasterfrom
Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Contributor
|
👋 A new build is available for this PR based on 498994a. |
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Following up on #3109
This PR adds a Post Execution Downloads field to the Action editor for Local Actions only.
Other types of action will not display that field in the editor.
That field could only be added and edited manually from the settings/actions.json files. It can now also be changed from the editor.
The
postDownloadfield also now supports variables replacement when the action is executed.The PR also makes sure that some optional action fields are cleaned up before being saved to avoid writing blank strings/empty array in the settings.
How to test this PR
Checklist