Reimplement project gallery as static content #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load projects CSV at build time as a data file. Pass modal content to JavaScript via HTML data attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new include loads the projects CSV file as a data file and constructs the project gallery all at build time, replacing JavaScript code that built the HTML at runtime. This eliminates the dependency on the PapaParse library.
The modal works again. The modal’s content is now baked into the static webpage as a series of HTML data attributes on the card’s container element. The button that opens the modal passes the DOM element to the code that populates the modal.
Deleted the mostly redundant script for populating the homepage version of the project gallery. Instead, the include accepts optional parameters to filter the gallery and/or limit to a maximum number of results.
Updated the website’s own project card to mention the technologies and skills this project uses.
Fixes #112 and fixes #118.