fix: SQLSRV driver's decrement() method#10155
Draft
patel-vansh wants to merge 1 commit intocodeigniter4:developfrom
Draft
fix: SQLSRV driver's decrement() method#10155patel-vansh wants to merge 1 commit intocodeigniter4:developfrom
decrement() method#10155patel-vansh wants to merge 1 commit intocodeigniter4:developfrom
Conversation
Contributor
Author
|
I am quite unsure about the tests in this case. Do I need to add a new file in tests/system/Database/Live/SQLSRV directory? Or add a particular test inside the normal |
5 tasks
Member
|
The new class under the SQLSRV directory would be better. Please add tests for both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discovered by @paulbalandan in this comment, SQLSRV Database Driver was incorrectly adding instead of subtracting the decrement value when
$castTextToIntwas false.This PR fixes that bug by flipping the sign in
decrement()function.Checklist: