feat: support objects in remaining dot array helpers#10296
Open
michalsn wants to merge 4 commits into
Open
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces #10269. It extends the remaining dot-path helpers so
dot_array_has(),dot_array_only(), anddot_array_except()can read through array-like object values while keeping the existing array return contract for projection helpers.The code now uses one lookup path for arrays and objects. It preserves keys from traversable objects and does not convert objects that are not part of the requested path. If an object is returned or left untouched, it stays an object. If only part of an object is selected or removed, that part is returned as an array.
Supersedes #10269
Closes #10225
Checklist: