Avoid adding blank highlight terms in WildcardQueryCommand #2875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the handling of highlighted queries in the WildcardQueryCommand by ensuring that blank or whitespace-only strings are not added as highlighted queries. It also adds a StringUtil import to leverage its isNotBlank validation for cleaner code.
- Validates highlighted query strings before addition in three parts of the convertWildcardQuery method.
- Introduces a minor import change to use StringUtil.isNotBlank.
marevol
added a commit
that referenced
this pull request
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of highlighted queries in the
WildcardQueryCommandclass by introducing additional validation to ensure that only non-blank strings are added as highlighted queries. It also includes a minor import addition for utility functions.Improvements to highlighted query handling:
convertWildcardQuerymethod to validate that the stripped query text is not blank before adding it as a highlighted query. This ensures that empty or whitespace-only strings are not unnecessarily processed. (src/main/java/org/codelibs/fess/query/WildcardQueryCommand.java, [1] [2]Codebase enhancements:
StringUtilimport to leverage itsisNotBlankutility method for improved readability and functionality. (src/main/java/org/codelibs/fess/query/WildcardQueryCommand.java, src/main/java/org/codelibs/fess/query/WildcardQueryCommand.javaR25)…ipping