fix(thumbnail): escape + character in SVG MIME type regex pattern#3032
Merged
fix(thumbnail): escape + character in SVG MIME type regex pattern#3032
Conversation
The MIME type condition for SVG thumbnail generation was using "image/svg+xml" as a regex pattern without escaping the + character. In regex, + is a special character meaning "one or more", which caused the pattern to not match the literal "image/svg+xml" string. Changed the pattern to "image/svg\+xml" to properly match the SVG MIME type and enable thumbnail generation for SVG files. Added test case to verify the regex pattern matching behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed an issue where SVG thumbnails were not being generated due to incorrect regex pattern matching for the
image/svg+xmlMIME type.Changes Made
image/svg+xmltoimage/svg\+xmlto properly escape the+character for regex matchingtest_mimetypePatternMatching()to verify regex pattern behavior and prevent regressionProblem
The
+character in regex means "one or more of the preceding element", so the patternimage/svg+xmlwas being interpreted as "image/svg" followed by one or more "x" followed by "ml". This caused the pattern to not match the literal stringimage/svg+xml.Solution
Escaped the
+character with a backslash (\+) so it matches the literal+in the MIME type string.Testing
image/svg+xmlimage/svg+xml🤖 Generated with Claude Code