Skip to content

Added button and navbar components #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

liiam-dsouza
Copy link

No description provided.

@McCorsa McCorsa linked an issue Mar 13, 2025 that may be closed by this pull request
@liiam-dsouza
Copy link
Author

Mobile menu may still need some work if we want it to look different to how it looks on desktop. Other than that, I think everything is there

@McCorsa
Copy link
Contributor

McCorsa commented Apr 19, 2025

I've just pushed a commit with the missing dependencies and I've taken another look at how things are functioning. I'm finding that when I click "Projects" in the navbar, the menu opens fine. It's when I click the down arrow that it just turns around and does nothing. I'm going to hold off from accepting the PR until we can work out why this is happening.

@McCorsa
Copy link
Contributor

McCorsa commented Apr 19, 2025

I've made a minor change to the selector for detecting areas to click-off. For some reason, it looks like the chevron navigation menu icon was being seen as a separate object and was causing the site to think I was clicking off the menu. Happy to merge this if you are happy with how the nav menu is looking.

@liiam-dsouza
Copy link
Author

Happy with how it looks, merge it.

@McCorsa
Copy link
Contributor

McCorsa commented Apr 19, 2025

Keeping the PR open to allow time for the mobile navbar to be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website navbar
2 participants